Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4721C33CAF for ; Thu, 16 Jan 2020 18:21:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B084920684 for ; Thu, 16 Jan 2020 18:21:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579198912; bh=tfIoS93B0aTHiVnB1lKZjdoADg62rCABGH7ZfwMWtz8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=IDbpK6vMhdi0cVNR7uck4Ik5AsHx9AIlCgk4ItFy1LHzzTiE6O0kfBC+yzYcaL6dF llvq9m9iDt3Eb1l4VHGCbMJZBxTLeBBq0qKLj6D6UQRtG4Pg1t7VVSF7rF2o+ktnTX BtXLcPe8hGRQo3nIeTttEOfOyxGMBuOMgiPNMpIg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436497AbgAPSVv (ORCPT ); Thu, 16 Jan 2020 13:21:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:37794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392492AbgAPR1n (ORCPT ); Thu, 16 Jan 2020 12:27:43 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 606BF246DD; Thu, 16 Jan 2020 17:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579195662; bh=tfIoS93B0aTHiVnB1lKZjdoADg62rCABGH7ZfwMWtz8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hOQNa8JamiWFYvwlcov/24zePh4gXKgJ5rrXMMztGSogD+1AMt5+YKUGVNqiz/haz 53A1Bo0DXIdrLHZ+JUif+eWymx0DRMU5T01lusqlM3bH/NCHBvGwDigWz4oTUh8UQs yA1xFBOVIVjGjINhJCiV/STaangR5CNaNEm4jI7s= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Stephen Hemminger , Stephen Hemminger , "David S . Miller" , Sasha Levin , linux-hyperv@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 221/371] netvsc: unshare skb in VF rx handler Date: Thu, 16 Jan 2020 12:21:33 -0500 Message-Id: <20200116172403.18149-164-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116172403.18149-1-sashal@kernel.org> References: <20200116172403.18149-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Stephen Hemminger [ Upstream commit 996ed04741467f6d1552440c92988b132a9487ec ] The netvsc VF skb handler should make sure that skb is not shared. Similar logic already exists in bonding and team device drivers. This is not an issue in practice because the VF devicex does not send up shared skb's. But the netvsc driver should do the right thing if it did. Fixes: 0c195567a8f6 ("netvsc: transparent VF management") Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/hyperv/netvsc_drv.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index a89de5752a8c..9e48855f6407 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -1840,6 +1840,12 @@ static rx_handler_result_t netvsc_vf_handle_frame(struct sk_buff **pskb) struct netvsc_vf_pcpu_stats *pcpu_stats = this_cpu_ptr(ndev_ctx->vf_stats); + skb = skb_share_check(skb, GFP_ATOMIC); + if (unlikely(!skb)) + return RX_HANDLER_CONSUMED; + + *pskb = skb; + skb->dev = ndev; u64_stats_update_begin(&pcpu_stats->syncp); -- 2.20.1