Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D1CBC33CAF for ; Thu, 16 Jan 2020 18:14:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3AD5620684 for ; Thu, 16 Jan 2020 18:14:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579198446; bh=gNFwEQOsiuqgaNAr1jQlS1TSYe0ExSz1VKzlHHfJk4g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hiz5xLmOKFlDnlbtCpF4K7crrEHzJ7Fy4VJGLJgpLaLaDEHZmAEKwUzsFgJdd3dL5 7ojU3BUTpt92objkZWN4JKfyHXRjUqMXSfJJL9dYDlWiY82BqLRDgXAK8MpDtFmjo7 xd9AjBnVOrPsI1dBtHYFk5/HROikjF3Rr1z0EK9s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395326AbgAPSOF (ORCPT ); Thu, 16 Jan 2020 13:14:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:49096 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404885AbgAPRfA (ORCPT ); Thu, 16 Jan 2020 12:35:00 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F972246C0; Thu, 16 Jan 2020 17:34:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196099; bh=gNFwEQOsiuqgaNAr1jQlS1TSYe0ExSz1VKzlHHfJk4g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NCgeQrZ5Wkd3aOcW4TuvQLYGTp6gvX3OqJUIIveN+48vhgJEtbXQRwuKe2OgawEyI JxfFKT4H0FP2DTX9l2FMGa3dS/TXe7HValnTGlWaYWrP9Ec4geKHgsTM21WR02uVu4 suP2vE/IUqQITDldvd4YXYfA0Zu2UQ1APS88NWac= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: YueHaibing , Al Viro , Sasha Levin Subject: [PATCH AUTOSEL 4.9 011/251] exportfs: fix 'passing zero to ERR_PTR()' warning Date: Thu, 16 Jan 2020 12:30:45 -0500 Message-Id: <20200116173445.21385-11-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116173445.21385-1-sashal@kernel.org> References: <20200116173445.21385-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: YueHaibing [ Upstream commit 909e22e05353a783c526829427e9a8de122fba9c ] Fix a static code checker warning: fs/exportfs/expfs.c:171 reconnect_one() warn: passing zero to 'ERR_PTR' The error path for lookup_one_len_unlocked failure should set err to PTR_ERR. Fixes: bbf7a8a3562f ("exportfs: move most of reconnect_path to helper function") Signed-off-by: YueHaibing Signed-off-by: Al Viro Signed-off-by: Sasha Levin --- fs/exportfs/expfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/exportfs/expfs.c b/fs/exportfs/expfs.c index 3706939e5dd5..1730122b10e0 100644 --- a/fs/exportfs/expfs.c +++ b/fs/exportfs/expfs.c @@ -146,6 +146,7 @@ static struct dentry *reconnect_one(struct vfsmount *mnt, tmp = lookup_one_len_unlocked(nbuf, parent, strlen(nbuf)); if (IS_ERR(tmp)) { dprintk("%s: lookup failed: %d\n", __func__, PTR_ERR(tmp)); + err = PTR_ERR(tmp); goto out_err; } if (tmp != dentry) { -- 2.20.1