From: Tom Rini Date: Sat, 18 Jan 2020 17:00:52 -0500 Subject: [PATCH] arm: Enable VIDEO_BPP32 on pinebook. In-Reply-To: <8736ccr0qx.fsf@ponder> References: <20200118111516.2869-1-vagrant@debian.org> <20200118112932.lqgvusgn3p56jipr@gilmour.lan> <8736ccr0qx.fsf@ponder> Message-ID: <20200118220052.GM8732@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sat, Jan 18, 2020 at 12:03:02PM -0800, Vagrant Cascadian wrote: > On 2020-01-18, Maxime Ripard wrote: > > On Sat, Jan 18, 2020 at 03:15:15AM -0800, Vagrant Cascadian wrote: > >> Video output on the pinebook LCD screen was broken by: > >> > >> commit 2cc393f32fd9 ("video: make BPP and ANSI configs optional"). > >> > >> Enable VIDEO_BPP32 which was previously enabled by default when > >> DM_VIDEO was set. > >> > >> Signed-off-by: Vagrant Cascadian > > > > There's nothing really specific about the pinebook here, but it's > > needed for pretty much all the boards using DM_VIDEO (on Allwinner at > > least). > > > > You should add a kconfig select / default instead > > That would basically revert 2cc393f32fd9, and I figured there was a > reason for it... > > It wouldn't surprise me that other systems are affected, but I only > notice this issue on the pinebook (most of the systems I use are > headless), where it definitely needed to be fixed somehow. > > If there's a correct and more general fix, please propose it! Well, looking at 2cc393f32fd9 there are a number of platforms that enable more than one mode. But maybe we should always have at least one mode? -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: