Content-Type: multipart/mixed; boundary="===============0812339430662681251==" MIME-Version: 1.0 From: Stefano Brivio To: kbuild-all@lists.01.org Subject: Re: [PATCH nf-next v3 5/9] nf_tables: Add set type for arbitrary concatenation of ranges Date: Mon, 20 Jan 2020 23:05:41 +0100 Message-ID: <20200120230541.64a3a556@elisabeth> In-Reply-To: <202001202149.6obFNaHi%lkp@intel.com> List-Id: --===============0812339430662681251== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, 21 Jan 2020 00:13:17 +0800 kbuild test robot wrote: > All errors (new ones prefixed by >>): > = > >> ERROR: "__udivdi3" [net/netfilter/nf_tables_set.ko] undefined! > >> ERROR: "__divdi3" [net/netfilter/nf_tables_set.ko] undefined! = Right, this needs: diff --git a/net/netfilter/nft_set_pipapo.c b/net/netfilter/nft_set_pipapo.c index 5946fba8eb84..f0cb1e13af50 100644 --- a/net/netfilter/nft_set_pipapo.c +++ b/net/netfilter/nft_set_pipapo.c @@ -1925,7 +1925,7 @@ static bool nft_pipapo_estimate(const struct nft_set_= desc *desc, u32 features, = /* Rules in lookup and mapping tables are needed for each entry */ est->size =3D desc->size * entry_size; - if (est->size && est->size / desc->size !=3D entry_size) + if (est->size && div_u64(est->size, desc->size) !=3D entry_size) return false; = est->size +=3D sizeof(struct nft_pipapo) + I will change that in the next version. -- = Stefano --===============0812339430662681251==--