Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A4FEC32771 for ; Wed, 22 Jan 2020 05:09:58 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id BB887217F4 for ; Wed, 22 Jan 2020 05:09:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gGhRboPi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB887217F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2EAFD2BF2; Wed, 22 Jan 2020 06:09:53 +0100 (CET) Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by dpdk.org (Postfix) with ESMTP id 44E842B98 for ; Wed, 22 Jan 2020 06:09:51 +0100 (CET) Received: by mail-qt1-f196.google.com with SMTP id e25so4646373qtr.13 for ; Tue, 21 Jan 2020 21:09:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+HWqLPGvafi/EEButAzGQffKPn7NTaqHk6muJyOV6KY=; b=gGhRboPi+/L05EBgBgheeRW5x0Y30OVR+mfQEGN9bNAHLl4BrbFERZ8PsI59Kt9S95 GZvY3Y0aquEo5/flgqjsmr1FyUEzxCsW+TcmHVL4+9flxQDwcnKoSpnEkjCECKqnch9K qWACqDOsOot5MCaNmoDjam43phor9AidSLBpwoq8Eizec3kBVPkhPF1gNhfHkPxMLWAp rxpf7kXcFKclpNhyUX1NwGnylkusID8eFg2V/L8Lk9/nlD3WGqbHEIsWqgRC9eIVCLgZ uTMVTvoqQbOwEFCzy6PJDvWalo8f5wHktQKYtjeo4n/+2Bp2YyEAuSuAg9OMEU+4kbC0 Htgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+HWqLPGvafi/EEButAzGQffKPn7NTaqHk6muJyOV6KY=; b=ENCe+90/K8j92J0odUpujZoXToCxmB1/n0SBHT1vf/f0Op5Q8cbEF3GH2XiEIX2s8x SoDAZFvUPgg0ShkvlcBXsa6Ynjw2LU/NOx1Hr5HIjoMaq+s2xApRCgPUCV+5AR9mdL9D mIamQTuSe1Pfxs2meypNwjNrlvd+TIuWP8ArZAf82meem865JMCVdcp8nPe7CIcuOgGs 1xQGtwBAwVjuYerWEuvuEw2ovO1+dDkwkAEBpqY/gyKKQjmakqv1ZxztDDyfLfRKwigM D5XlmDDJ7IXeUMqJhoL2VvzNPJyeei9dNUZ7CaEqPp+Kfrni/XSvAxONujgBrH06qBLZ wsyw== X-Gm-Message-State: APjAAAUyx/I5Zxvq7sUjM90D+veRiYZ4UCP1H0v4iRQewWBRXi+tzKah 2gPmGohQ7goXTbPRiLvpoXE= X-Google-Smtp-Source: APXvYqxB1WbDfb9w3HCSE5Kd4RVN4VelkcefgQX1K6Xsi7yhTn2BGx4yH9DYBl7UKbztk8IbLzvmrQ== X-Received: by 2002:ac8:f02:: with SMTP id e2mr8030831qtk.216.1579669790487; Tue, 21 Jan 2020 21:09:50 -0800 (PST) Received: from localhost.localdomain (pool-71-182-232-12.pitbpa.fios.verizon.net. [71.182.232.12]) by smtp.gmail.com with ESMTPSA id v24sm20266955qtq.14.2020.01.21.21.09.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 21:09:50 -0800 (PST) From: Dominic Chen To: Wenzhuo Lu Cc: dev@dpdk.org, Dominic Chen Date: Wed, 22 Jan 2020 00:09:39 -0500 Message-Id: <20200122050940.4695-2-d.c.ddcc@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200122050940.4695-1-d.c.ddcc@gmail.com> References: <20200122050940.4695-1-d.c.ddcc@gmail.com> Subject: [dpdk-dev] [PATCH 2/2] net/e1000: assume device ID as workaround for Intel 82574L bug in VMware X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" VMware Workstation 15.5.1 doesn't correctly emulate the PHY_ID_R2 register, so assume that it has the correct value. Signed-off-by: Dominic Chen --- drivers/net/e1000/base/e1000_82571.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/e1000/base/e1000_82571.c b/drivers/net/e1000/base/e1000_82571.c index 157b953cd..9022cbb4a 100644 --- a/drivers/net/e1000/base/e1000_82571.c +++ b/drivers/net/e1000/base/e1000_82571.c @@ -153,6 +153,13 @@ STATIC s32 e1000_init_phy_params_82571(struct e1000_hw *hw) ret_val = -E1000_ERR_PHY; break; case e1000_82574: + if (phy->id == 0) { + RTE_LOG(WARNING, PMD, + "Warning: Assuming device ID for Intel 82574 NIC, workaround for VMware Workstation bug\n"); + /* VMWare Workstation 15.5.1 returns zero */ + phy->id = BME1000_E_PHY_ID_R2; + } + /* fall through */ case e1000_82583: if (phy->id != BME1000_E_PHY_ID_R2) ret_val = -E1000_ERR_PHY; -- 2.17.1