From: Wolfgang Denk Date: Fri, 24 Jan 2020 14:19:36 +0100 Subject: [PATCH] env: add prototypes for weak function In-Reply-To: <20200124124142.392-1-patrick.delaunay@st.com> References: <20200124124142.392-1-patrick.delaunay@st.com> Message-ID: <20200124131936.48EEC24065B@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Patrick, In message <20200124124142.392-1-patrick.delaunay@st.com> you wrote: > > +/* allows to set ext4 interface */ > +const char *env_ext4_get_intf(void); Are you sure these comments are correct? A "get interface" function is not supposed to set anything? > +/* allows to set ext4 device and partition */ > +const char *env_ext4_get_dev_part(void); A "get device and partition" function is not supposed to set anything? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A Puritan is someone who is deathly afraid that someone, somewhere, is having fun.