From: Tom Rini Date: Fri, 24 Jan 2020 14:52:15 -0500 Subject: [PATCH v2 0/7] Add Cortina Access basic DM drivers In-Reply-To: <18157543-DB21-4A35-97EA-CC9FCF19AC8A@cortina-access.com> References: <1579601912-27737-1-git-send-email-alex.nemirovsky@cortina-access.com> <20200124151330.GQ26536@bill-the-cat> <13D32E42-263A-4922-AF73-F5D284EA1295@cortina-access.com> <20200124173714.GT26536@bill-the-cat> <84ED7BF2-CF79-4F2C-936C-289CDC4DFCCF@cortina-access.com> <20200124183013.GU26536@bill-the-cat> <20200124184222.GV26536@bill-the-cat> <18157543-DB21-4A35-97EA-CC9FCF19AC8A@cortina-access.com> Message-ID: <20200124195215.GW26536@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de On Fri, Jan 24, 2020 at 06:58:13PM +0000, Alex Nemirovsky wrote: > one last thing, since we are moving SoC code out of the board tree. > would you prefer each SoC specific header directly in top level > include directory or within nclude/cortina subdirectory? i.e. > include/ca7774.h vs include/cortina/ca7774.h? Inside of arch/arm/include/asm/mach-caxxxx/ you can split things how you think makes the most sense. There's many other examples to look at here. >=20 > > On Jan 24, 2020, at 10:42 AM, Tom Rini wrote: > >=20 > > On Fri, Jan 24, 2020 at 06:34:40PM +0000, Alex Nemirovsky wrote: > >=20 > >> Sounds good Tom. We will send the next series with the ARMv8 low_level= .S moved to arch/mach-caxxxx/ > >> Thanks for you guidance. Did you see anything else in 2nd series that= needs modified before we send=20 > >> series 3 or can we assume those are fine to avoid sending another seri= es after this issues is fixed in series 3? > >=20 > > That was all I noticed, thanks again. > >=20 > >>=20 > >>> On Jan 24, 2020, at 10:30 AM, Tom Rini wrote: > >>>=20 > >>> On Fri, Jan 24, 2020 at 05:55:29PM +0000, Alex Nemirovsky wrote: > >>>> Looking inside > >>>> grep -h CA board/cortina/common/armv8/lowlevel_init.S > >>>> #if defined(CONFIG_SOC_CA7774) > >>>> #if defined(CONFIG_SOC_CA8277B) > >>>>=20 > >>>> as we understand it, the alternative would lead to maintaining dupli= cate but slightly different code for each ARM based SoC in > >>>> arch/arm/mach-ca7774 > >>>> arch/arm/mach-ca8277B > >>>> arch/arm/mach-ca7742 > >>>> arch/arm/mach-ca8279 > >>>> arch/arm/mach-caXnnn > >>>>=20 > >>>> correct? or should we simply create a arch/arm/mach-caxxxx, arch/mi= ps/mach-caxxxx, arch/xtensa/mach-axxxx, arch/riscv/mach-caxxxx, etc to mai= ntain similar > >>>> changes to each arch related custom code which varies slightly for e= ach SoC variation within each architecture? > >>>> What=E2=80=99s best to avoid maintaining duplicate code across SoC v= ariations within the same ISA family? > >>>=20 > >>> I would hope we can get by with arch/arm/mach-caxxxx or so and > >>> board/cortina/common/. How are you handling common code in the linux > >>> kernel? > >>>=20 > >>> --=20 > >>> Tom > >>=20 > >=20 > > --=20 > > Tom >=20 --=20 Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: