Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB314C32771 for ; Mon, 27 Jan 2020 09:06:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE159214DB for ; Mon, 27 Jan 2020 09:06:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="AJL05RC9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE159214DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 32C966EA6E; Mon, 27 Jan 2020 09:06:02 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id A63F16EA6E for ; Mon, 27 Jan 2020 09:06:01 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id q9so5943398wmj.5 for ; Mon, 27 Jan 2020 01:06:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=skD6KsbNTC8YBufTx8994xeXMmd4LfxtNfKHHZSZCCY=; b=AJL05RC9RoDfUiHa6C7xxV56b4sdHOTDCYY4TtWFrJFHLyjCxrG3407rseG2rXVPuG hKC/qEjXeJQbHLnl3RKWbDwNtmnNS8PVmakd83ftgjoxJhrAeS0CTn7y/UpcHhdIGokv MzaFHBxUKO1QwykBt9FZhgOlYtIQL9G1z/csE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=skD6KsbNTC8YBufTx8994xeXMmd4LfxtNfKHHZSZCCY=; b=M4U8wTciI6LiwhyxUODH6ZqLlh/DNW6Bca3CMhHKpVhhIquejfMb249EewugTtTJTw VuMFlx5qtA0XdIF7AdjV/ZUedlkGORlSVrShjojt90JQeJi0+dkoDixJNSugD4q1x9wN Aeaj/m+x5IH7/HiMbtdQGaROLTnDHNY3QuWuAPo6Wczic6Z40H4M0SjAIaESCv7rcLc6 +D8d8gH6/nnvq6LLBr5uSleNeCsbfTUj7NfHTJ6ipBGuxz2edYjCIvmESJ/tBU7wutj6 5iGVpRsleXjH3ZWozSYq2H7ORA7Hgdp4zqyqzOqv25jQH5tcQtHdOb0YDuiaaeR+KXf9 dvAw== X-Gm-Message-State: APjAAAU2gNHMcxXU/0ZaVGGbGqjonYJ1nx0XxB8jGi3tm8sYBeA/PGA6 8hregtUmGl+BQ9ZiC12arwdCiw== X-Google-Smtp-Source: APXvYqz7HgDc75LeHLHMNJ1pvjtFzSNhVwrleSA9jWJFlTZ+Be7nFmdMno9WF/N8WTsD3Fbz/nVZKw== X-Received: by 2002:a1c:a4c3:: with SMTP id n186mr10813787wme.25.1580115960316; Mon, 27 Jan 2020 01:06:00 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id c2sm19726310wrp.46.2020.01.27.01.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jan 2020 01:05:59 -0800 (PST) Date: Mon, 27 Jan 2020 10:05:57 +0100 From: Daniel Vetter To: Chris Wilson Subject: Re: [PATCH 0/2] drm/i915/gem: conversion to new drm logging macros Message-ID: <20200127090557.GU43062@phenom.ffwll.local> Mail-Followup-To: Chris Wilson , Wambui Karuga , airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, linux-kernel@vger.kernel.org, rodrigo.vivi@intel.com References: <20200122125750.9737-1-wambui.karugax@gmail.com> <157996851987.2524.2577321446102599250@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <157996851987.2524.2577321446102599250@skylake-alporthouse-com> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, rodrigo.vivi@intel.com, Wambui Karuga Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Jan 25, 2020 at 04:08:39PM +0000, Chris Wilson wrote: > Quoting Wambui Karuga (2020-01-22 12:57:48) > > This series is a part of the conversion to the new struct drm_device > > based logging macros in drm/i915. > > This series focuses on the drm/i915/gem directory and converts all > > straightforward instances of the printk based logging macros to the new > > macros. > > Overall, I'm not keen on this as it perpetuates the mistake of putting > client debug message in dmesg and now gives them even more an air of > being device driver debug messages. We need a mechanism by which we > report the details of what a client did wrong back to that client > (tracefs + context/client getparam to return an isolated debug fd is my > idea). Sean is working on that, but it's a global thing still. Well since it's tracefs should be easy to filter for a given process at least. We've had long discussion about how to expose that, big fear (especially with atomic) is that clients/compositors will start to look at random debug strings and make them uapi. But I think for stuff like igt we should be able to wire it up easily and get it dumped when things go wrong. Maybe similar when mesa gets an unexpected errno. -Daniel > > Wambui Karuga (2): > > drm/i915/gem: initial conversion to new logging macros using > > coccinelle. > > drm/i915/gem: manual conversion to struct drm_device logging macros. > > Still this is a necessary evil for the current situation, > Acked-by: Chris Wilson > -Chris -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel