From: Wolfgang Denk Date: Tue, 28 Jan 2020 14:53:56 +0100 Subject: [PATCH v4 01/10] env: nowhere: set default enviroment In-Reply-To: <927f859e-9c93-2731-c69e-e491219a818a@ti.com> References: <20200122040005.7573-1-j-keerthy@ti.com> <20200122040005.7573-2-j-keerthy@ti.com> <20200124145239.GN26536@bill-the-cat> <20200127133417.36360240014@gemini.denx.de> <20200127141233.GF9259@bill-the-cat> <927f859e-9c93-2731-c69e-e491219a818a@ti.com> Message-ID: <20200128135356.E1551240014@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Keerthy, In message <927f859e-9c93-2731-c69e-e491219a818a@ti.com> you wrote: > > >>>>> --- a/env/nowhere.c > >>>>> +++ b/env/nowhere.c > >>>>> @@ -23,6 +23,7 @@ static int env_nowhere_init(void) > >>>>> { > >>>>> gd->env_addr = (ulong)&default_environment[0]; > >>>>> gd->env_valid = ENV_INVALID; > >>>>> + (NULL, 0); > >> > >> ^^^^^^^^^^^^^^^^^^^^^^ > >> You are inserting this line of "C code" only. > > > > I think something got ate along the way. The patch is at > > http://patchwork.ozlabs.org/patch/1226946/ > > and the full line is: > > + env_set_default(NULL, 0); > > env_set_default(NULL, 0); sets the required flag for us in the nowhere > path as well. I see. Sorry, I didn't read the original patch. As you see in the quote above, the "env_set_default" somehow got lost, and this was what triggered my comment. Feel free to ignore it. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Love all, trust a few. - William Shakespeare