From: Tom Rini Date: Wed, 29 Jan 2020 10:35:31 -0500 Subject: [PATCH] gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO In-Reply-To: References: <20200129144115.12789-1-festevam@gmail.com> <20200129145508.GC13379@bill-the-cat> Message-ID: <20200129153531.GD13379@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jan 29, 2020 at 11:57:00AM -0300, Fabio Estevam wrote: > On Wed, Jan 29, 2020 at 11:55 AM Tom Rini wrote: > > > OK, why is the fix to do what you did here and NOT enable > > CONFIG_SPL_GPIO on the platform(s) in question to match the rest of > > Because mx7dsabresd_defconfig does not support SPL. Ah. But it is DM_GPIO? I think looking at bcee8d6764f9 there's a few other i.MX boards that are also broken something needs to be moved to Kconfig / updated still. In fact, uh, there's a good bit of confusion around that line in the Makefile. The test on 'CONFIG_$(SPL_TPL_)GPIO' will never be true as there is only 'DM_GPIO' (and SPL/TPL variants) and 'SPL/TPL_GPIO_SUPPORT' and no 'GPIO' itself. So everyone using 74x164_gpio.o is broken right now. Do you want to take a pass at trying to unpack and fix this mess or should I? Thanks again! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: