From: Boris Brezillon Subject: Re: [PATCH v4 5/6] media: rkvdec: Add the rkvdec driver Date: Thu, 30 Jan 2020 17:12:49 +0100 Message-ID: <20200130171249.3ae0444a@collabora.com> References: <20200129195501.8317-1-ezequiel@collabora.com> <20200129195501.8317-6-ezequiel@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200129195501.8317-6-ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ezequiel Garcia Cc: linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Laurent Pinchart , Rob Herring , Tomasz Figa , Nicolas Dufresne , kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, Paul Kocialkowski , Jonas Karlman , Heiko Stuebner , Sakari Ailus , Hans Verkuil List-Id: linux-rockchip.vger.kernel.org On Wed, 29 Jan 2020 16:55:00 -0300 Ezequiel Garcia wrote: > From: Boris Brezillon > > The rockchip vdec block is a stateless decoder that's able to decode > H264, HEVC and VP9 content. This commit adds the core infrastructure > and the H264 backend. Support for VP9 and HEVS will be added later on. > > Signed-off-by: Boris Brezillon > Signed-off-by: Ezequiel Garcia > --- > v4: > * Make poc tables const, as suggested by Hans > * Move buffer extra space calculation TRY_FMT, as done on Hantro. > * Get rid of vb2_request_get_buf and open-code > following Cedrus. We can move it to a helper as a follow-up patch. Well, we know what that means in practice :-). > new file mode 100644 > index 000000000000..1293b3621364 > --- /dev/null > +++ b/drivers/staging/media/rkvdec/rkvdec-regs.h > @@ -0,0 +1,239 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Rockchip VPU codec driver > + * > + * Copyright (C) 2015 Rockchip Electronics Co., Ltd. > + * Jung Zhao > + * Alpha Lin > + * > + * This software is licensed under the terms of the GNU General Public > + * License version 2, as published by the Free Software Foundation, and > + * may be copied, distributed, and modified under those terms. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ Oops, looks like I forgot to remove the license text here. Also not entirely sure the copyrights are correct (might be a copy from the hantro driver instead of the rkvdec one). > diff --git a/drivers/staging/media/rkvdec/rkvdec.h b/drivers/staging/media/rkvdec/rkvdec.h > new file mode 100644 > index 000000000000..529ef86510d3 > --- /dev/null > +++ b/drivers/staging/media/rkvdec/rkvdec.h > @@ -0,0 +1,124 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Hantro VPU codec driver > + * > + * Copyright 2018 Google LLC. > + * Tomasz Figa > + * > + * Based on s5p-mfc driver by Samsung Electronics Co., Ltd. > + * Copyright (C) 2011 Samsung Electronics Co., Ltd. > + */ This header has been copied from the hantro driver, so it's most likely wrong.