Date: Tue, 11 Feb 2020 12:33:31 -0500 From: Vivek Goyal Message-ID: <20200211173331.GC8590@redhat.com> References: <20200109112447.GG27035@quack2.suse.cz> <20200114203138.GA3145@redhat.com> <20200114212805.GB3145@redhat.com> <20200115195617.GA4133@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Virtio-fs] [PATCH 01/19] dax: remove block device dependencies List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dan Williams Cc: virtio-fs@redhat.com, Jan Kara , Miklos Szeredi , "Darrick J. Wong" , Dave Chinner , Linux Kernel Mailing List , Christoph Hellwig , linux-nvdimm , Jeff Moyer , linux-fsdevel On Thu, Jan 16, 2020 at 10:09:46AM -0800, Dan Williams wrote: > On Wed, Jan 15, 2020 at 1:08 PM Jeff Moyer wrote: > > > > Hi, Dan, > > > > Dan Williams writes: > > > > > I'm going to take a look at how hard it would be to develop a kpartx > > > fallback in udev. If that can live across the driver transition then > > > maybe this can be a non-event for end users that already have that > > > udev update deployed. > > > > I just wanted to remind you that label-less dimms still exist, and are > > still being shipped. For those devices, the only way to subdivide the > > storage is via partitioning. > > True, but if kpartx + udev can make this transparent then I don't > think users lose any functionality. They just gain a device-mapper > dependency. Hi Dan, Are you planning to look into making this work? We can easily disable partition scanning by specifying gendisk GENHD_FL_NO_PART_SCAN flag. But what about partition additiona path, ioctl(BLKPG_ADD_PARTITION). That does not seem to do any checks whether block device supports in kernel partitions or not. So kernel partitions (hence /dev/pmemXpY) objects are created anyway and this will conflict with all the new planned udev rules. If you block ioctl(BLKPG_ADD_PARTITION), then user space tools like parted and fdisk started breaking when trying to create a partition on /dev/pmeme0. IIUC, we have to allow partition table creation on /dev/pmem0 so that later kpartx can parse it and create dm-linear partitions. Thanks Vivek