Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7271C2BA83 for ; Wed, 12 Feb 2020 08:09:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 689C820714 for ; Wed, 12 Feb 2020 08:09:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 689C820714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0DB6A6B03FE; Wed, 12 Feb 2020 03:09:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 08BFC6B03FF; Wed, 12 Feb 2020 03:09:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E96746B0400; Wed, 12 Feb 2020 03:09:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id D423D6B03FE for ; Wed, 12 Feb 2020 03:09:49 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7F9A08248076 for ; Wed, 12 Feb 2020 08:09:49 +0000 (UTC) X-FDA: 76480751298.29.wave40_8fefbb8fa624c X-HE-Tag: wave40_8fefbb8fa624c X-Filterd-Recvd-Size: 4265 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Feb 2020 08:09:49 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id t2so1022021wrr.1 for ; Wed, 12 Feb 2020 00:09:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mWNR8NSNpO0Bl2CKSRCvCBTWEWrxN6txmVC2QQsJvlA=; b=h841A9VpeY4Di4OSb/K4FaEdGccElhqM2gcLGis7tXSJGSI3pH/a5shBCScxxVZglx dpL8V1CbLRkB7JAS/0QahK1QMRBlP3+Ho4UsfMRrCo7AbRhLgfDi8+3Meke7PHX/ZZ5a 0XXksRZNlvr0tnPc0CdvNYd2/lOpGBQBODM1mkVmYW6mwZXH6IIyJfmLdWFif9BdRvM6 TbGu1hdjFdlvXJdS4gVuLJOYOhpgxv9otu5sy+y7Xca/VNrO4SZaEdfdO1rVLgDiONVC NbdZJ9g0pnEJsHKqU6LrVD32PoXHqVRMgu4uywo6bms3fg3cAY47TZaxyccaEPxfDin4 DpHQ== X-Gm-Message-State: APjAAAX+RiLo+GPv14K5WzKktweG/n8hNt2mzXLp/k+TE/frVp3PKt3b Fy0mOp8jepfrZXvYKf94sVo= X-Google-Smtp-Source: APXvYqxTXKnfx3FFH0goWGtL6x0SsQ17kWIazgeliJhAHrEul9Tz4kkhx2jJG3D6HaU43bOvI0ZwWw== X-Received: by 2002:a5d:670a:: with SMTP id o10mr13711467wru.227.1581494987979; Wed, 12 Feb 2020 00:09:47 -0800 (PST) Received: from localhost (ip-37-188-227-72.eurotel.cz. [37.188.227.72]) by smtp.gmail.com with ESMTPSA id t13sm8590070wrw.19.2020.02.12.00.09.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2020 00:09:47 -0800 (PST) Date: Wed, 12 Feb 2020 09:09:45 +0100 From: Michal Hocko To: Linus Torvalds Cc: Andrew Morton , Johannes Weiner , Rik van Riel , linux-fsdevel , Linux-MM , Linux Kernel Mailing List , Dave Chinner , Yafang Shao , Roman Gushchin , Al Viro , kernel-team@fb.com Subject: Re: [PATCH] vfs: keep inodes with page cache off the inode shrinker LRU Message-ID: <20200212080945.GA11353@dhcp22.suse.cz> References: <20200211175507.178100-1-hannes@cmpxchg.org> <29b6e848ff4ad69b55201751c9880921266ec7f4.camel@surriel.com> <20200211193101.GA178975@cmpxchg.org> <20200211154438.14ef129db412574c5576facf@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 11-02-20 16:28:39, Linus Torvalds wrote: > On Tue, Feb 11, 2020 at 3:44 PM Andrew Morton wrote: > > > > Testing this will be a challenge, but the issue was real - a 7GB > > highmem machine isn't crazy and I expect the inode has become larger > > since those days. > > Hmm. I would say that in the intening years a 7GB highmem machine has > indeed become crazy. Absolutely agreed. > It used to be something we kind of supported. And it's been few years since we have been actively discouraging people from using 32b kernels with a lot of memory. There are bug reports popping out from time to time but I do not remember any case where using 64b kernel would be a no-go. So my strong suspicion is that people simply keep their kernels on 32b without a good reason because it tends to work most of the time until they hit one of the lowmem problems and they move over to 64b. > But we really should consider HIGHMEM to be something that is on the > deprecation list. In this day and age, there is no excuse for running > a 32-bit kernel with lots of physical memory. > > And if you really want to do that, and have some legacy hardware with > a legacy use case, maybe you should be using a legacy kernel. > > I'd personally be perfectly happy to start removing HIGHMEM support again. I wouldn't be opposed at all. -- Michal Hocko SUSE Labs