Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA31CC2BA83 for ; Fri, 14 Feb 2020 11:36:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7451E222C4 for ; Fri, 14 Feb 2020 11:36:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728062AbgBNLgZ (ORCPT ); Fri, 14 Feb 2020 06:36:25 -0500 Received: from foss.arm.com ([217.140.110.172]:59992 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727652AbgBNLgZ (ORCPT ); Fri, 14 Feb 2020 06:36:25 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A64C01FB; Fri, 14 Feb 2020 03:36:24 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A47E93F68F; Fri, 14 Feb 2020 03:36:23 -0800 (PST) Date: Fri, 14 Feb 2020 11:36:07 +0000 From: Andre Przywara To: Marc Zyngier Cc: Julien Thierry , Suzuki K Poulose , , , Subject: Re: [PATCH v2] kvm: arm: VGIC: Fix interrupt group enablement Message-ID: <20200214113607.39854c81@donnerap.cambridge.arm.com> In-Reply-To: References: <20191122185142.65477-1-andre.przywara@arm.com> Organization: ARM X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 25 Nov 2019 10:55:01 +0000 Marc Zyngier wrote: Hi Marc, dug this out of my inbox, sorry for warming this up. > On 2019-11-22 18:51, Andre Przywara wrote: > > Hi Marc, > > > > this is still a bit rough, and only briefly tested, but I wanted to > > hear your opinion on the general approach (using a second list in > > addition to the ap_list). Some ugly bits come from the fact that the > > two lists are not that different, so we have to consider both of them > > at times. This is what I wanted to avoid with just one list that gets > > filtered on the fly. > > Or I am just stupid and don't see how it can be done properly ;-) > > I don't know about that, but I think there is a better way. > > You have essentially two sets of pending interrupts: > > 1) those that are enabled and group-enabled, that end up in the AP list > 2) those that are either disabled and/or group-disabled > > Today, (2) are not on any list. For a reason: because we don't really care about them. And so far they would only become interesting on an *individual* interrupt base, and our VGIC routines can deal very well with that. > What I'm suggesting is that we create > a list for these interrupts that cannot be forwarded. So the problem with that is that a list would need a list lock, and this is where things get hairy: - Either we introduce a separate disabled_list lock, adding to the nightmare of lock hierarchy we already have. I don't think that's really justifiable just because of group0 IRQs. - We piggy-back on an existing lock, like the ap_list_lock. The problem with that is that vgic_queue_irq_unlock takes and drops that lock, so we can't just iterate over this disabled list while holding that lock, and feed each IRQ to vgic_queue_irq_unlock() easily. One solution I was thinking about was something like: while (!list_empty(disabled_list)) { spin_lock(ap_list_lock); irq = remove_first_entry(disabled_list); spin_unlock(ap_list_lock); lock_irq(irq); /* re-check? */ vgic_queue_irq_unlock(irq); } Does that sound feasible? It's not really efficient nor nice, but I am not sure we care so much about this since we assume group enablement is rather rare. Cheers, Andre > Then enabling an interrupt or a group is a matter of moving pending > interrupts from one list to another. And I think most of the logic > can be hidden in vgic_queue_irq_unlock(). > > M.