Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47D21C2BA83 for ; Sat, 15 Feb 2020 19:04:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A80620726 for ; Sat, 15 Feb 2020 19:04:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="y2B+YiX0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726318AbgBOTEn (ORCPT ); Sat, 15 Feb 2020 14:04:43 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:47960 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726209AbgBOTEn (ORCPT ); Sat, 15 Feb 2020 14:04:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=pQwC1ecH4Pp04Gzec4Xs67vN8WVYg3FZkJDVS9U8n24=; b=y2B+YiX0E54FS1Gdn8hA9mzrFc rDB6m7GErolYNRnm/87sIHZe+8mvtlx61gvxgWG73yAzXaxETT6OGs1dO1kFKnA7LuPEsI0BIxGCC HkG+L2mlT5N5i6p8NGsVuXC2/mkcc98CgSlY0oLCzCXSsWQfIfPOk4rYro0gKyAvWMXk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1j32k3-0005Cl-IS; Sat, 15 Feb 2020 20:04:39 +0100 Date: Sat, 15 Feb 2020 20:04:39 +0100 From: Andrew Lunn To: Russell King Cc: Florian Fainelli , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net-next 08/10] net: phylink: allow ethtool -A to change flow control advertisement Message-ID: <20200215190439.GX31084@lunn.ch> References: <20200215154839.GR25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Feb 15, 2020 at 03:49:58PM +0000, Russell King wrote: > When ethtool -A is used to change the pause modes, the pause > advertisement is not being changed, but the documentation in > uapi/linux/ethtool.h says we should be. Add that capability to > phylink. > > Signed-off-by: Russell King Reviewed-by: Andrew Lunn Andrew