Return-Path: Received: from v1.tansi.org (mail.tansi.org [84.19.178.47]) by mail.server123.net (Postfix) with ESMTP for ; Thu, 20 Feb 2020 03:23:37 +0100 (CET) Received: from gatewagner.dyndns.org (81-6-44-245.init7.net [81.6.44.245]) by v1.tansi.org (Postfix) with ESMTPA id 04F441401CC for ; Thu, 20 Feb 2020 03:23:24 +0100 (CET) Date: Thu, 20 Feb 2020 03:23:35 +0100 From: Arno Wagner Message-ID: <20200220022335.GA29182@tansi.org> References: <7fc85398-a14e-bba1-c996-5d398fef8e7d@gmail.com> <9d9951e1-03a2-fcc5-8d2d-8b2276ab584c@yahoo.com> <0acf7f14-ae82-686a-bc13-847b01cd5aab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0acf7f14-ae82-686a-bc13-847b01cd5aab@gmail.com> Subject: Re: [dm-crypt] Bug in cryptsetup 2.3.0 (BitLocker key-file support) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: dm-crypt@saout.de On Wed, Feb 19, 2020 at 21:57:23 CET, Milan Broz wrote: > On 19/02/2020 21:13, Quentin Lefebvre wrote: > > The on-disk keyfile was the printed recovery passphrase provided by > > Windows... > > > > > So what is the exact content of your keyfile? Is there additional EOL, > > > or it had some more characters there? > > > > ls -l > > showed a 56 bytes file and > > > > hexdump -C > > showed a trailing '\x0a' character added by my favorite editor. > > > > Removing it with dd(!) solved my problem... > > ok, thanks for the info. > > But I think we should perhaps process even this file (recovery > passphrase has a special format - if it is detected, we try to use it, > otherwise we parse it as a normal passphrase). > I think we can do this even if it is has an additional EOL there. I would suggest giving a verbose warning in this case. Something like, "recovery passphrase detected, extra EOL chars stripped." Regards, Arno -- Arno Wagner, Dr. sc. techn., Dipl. Inform., Email: arno@wagner.name GnuPG: ID: CB5D9718 FP: 12D6 C03B 1B30 33BB 13CF B774 E35C 5FA1 CB5D 9718 ---- A good decision is based on knowledge and not on numbers. -- Plato If it's in the news, don't worry about it. The very definition of "news" is "something that hardly ever happens." -- Bruce Schneier