From: Petr Vorel Date: Thu, 20 Feb 2020 09:51:29 +0100 Subject: [LTP] [PATCH V2 04/10] syscalls/fsopen: New tests In-Reply-To: References: Message-ID: <20200220085129.GA11465@gacrux.arch.suse.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi, > > +static struct tcase { > > + char *name; > > + unsigned int flags; > > +} tcases[] = { > > + {"Flag 0", 0}, > > + {"Flag FSOPEN_CLOEXEC", FSOPEN_CLOEXEC}, > Maybe better to remove the 'Flag' keywords from here and add it to the > print sentence. +1. BTW if you remove bogus text, you can use macro to not repeat the flag, see testcases/kernel/syscalls/clock_nanosleep/clock_nanosleep01.c #define TYPE_NAME(x) .ttype = x, .desc = #x (just a suggestion, nothing really important) > > +static void run(unsigned int n) > > +{ > > ... > > + > > + if (!tst_ismount(MNTPOINT)) > > + tst_res(TPASS, "%s: fsopen() passed", tc->name); > tst_res(TPASS, "Flag %s: fsopen() passed", tc->name); Kind regards, Petr