Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 266CCC11D04 for ; Thu, 20 Feb 2020 13:06:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EFFB9206ED for ; Thu, 20 Feb 2020 13:06:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bfjYoYQI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728212AbgBTNGx (ORCPT ); Thu, 20 Feb 2020 08:06:53 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:42857 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728173AbgBTNGw (ORCPT ); Thu, 20 Feb 2020 08:06:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582204010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=epBBiJe/BiipnhOxinjfU345ql1651dsm1KJ2Eg1l+8=; b=bfjYoYQIdvSUNJgcPnZ+No7RJ0AOQUmt/GNL1KJR5bYTbYtEcQ/b8PYDmPmpp8p0XSy4LT O53drFKihzHqfpQAF2n1Qf+4uMGT0x5yZIiSL1z6dwOPqEzrARgcv4a5/gp2tCxIzK/Z6t WAOVEanOnP9y+U02rKOsYk03yOxaA+0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-215-2uZLGHPBMuqj9zUDjaCzNA-1; Thu, 20 Feb 2020 08:06:48 -0500 X-MC-Unique: 2uZLGHPBMuqj9zUDjaCzNA-1 Received: by mail-wr1-f69.google.com with SMTP id v17so1691267wrm.17 for ; Thu, 20 Feb 2020 05:06:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=epBBiJe/BiipnhOxinjfU345ql1651dsm1KJ2Eg1l+8=; b=aXRPvLdjYN6+CCGkYvnWDXbvJZDhlfT1QMgKTcGVhaoDPtCEWGziZf2p3X+bwMwDyo FQ5L8Sk5RYe7sfNCG9Uf3lCwusBJJmvafRN7EuwxdozjYAlsOWuBvRQFSB3LAzc426+K PHKI6cqrJSKBtRZnlmE2cZ7DSXFqQOolPfq4ENOIViMYRashvpsN8T10ZgP5Th3hO545 qlQvNmrbM/NZCccoMrSif9CiXqIu0QeU2voQ2s92JsDVjSfivJJ6F+/nDRDgbUlkS+sG RasaYR7qqpjRq3Mo9HiwAlcf+tb2euZTz6vIarKWy+NfFqv1sIBax5USUN3cgBSUifAF BOjQ== X-Gm-Message-State: APjAAAVApOnlg2XirYaMlIIthjTvcrKPQBh9C1b+sfECexxDa1rtUK6+ 9WySm4fqgn9MGZSjQE6X45dr3/u7Zxwa4BbQnEikNh0LCTy3RacntO1LkTT0/oOFuAZUHqka95W cTU9/G7BqcUHa X-Received: by 2002:a05:600c:295d:: with SMTP id n29mr4504811wmd.101.1582204006819; Thu, 20 Feb 2020 05:06:46 -0800 (PST) X-Google-Smtp-Source: APXvYqyzyX5Y7gdzaTOQjQ/rcWnepNEp6tk5YfOUODjdV1i7lhwV6s1r0NC2sbtsj+sn6/vQEc+xMg== X-Received: by 2002:a05:600c:295d:: with SMTP id n29mr4504765wmd.101.1582204006470; Thu, 20 Feb 2020 05:06:46 -0800 (PST) Received: from localhost.localdomain (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id b67sm4594690wmc.38.2020.02.20.05.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 05:06:45 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , qemu-devel@nongnu.org Cc: "Edgar E. Iglesias" , Anthony Perard , Fam Zheng , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , kvm@vger.kernel.org, Laurent Vivier , Thomas Huth , Stefan Weil , Eric Auger , Halil Pasic , Marcel Apfelbaum , qemu-s390x@nongnu.org, Aleksandar Rikalo , David Gibson , Michael Walle , qemu-ppc@nongnu.org, Gerd Hoffmann , Cornelia Huck , qemu-arm@nongnu.org, Alistair Francis , qemu-block@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Jason Wang , xen-devel@lists.xenproject.org, Christian Borntraeger , Dmitry Fleytman , Matthew Rosato , Eduardo Habkost , Richard Henderson , "Michael S. Tsirkin" , David Hildenbrand , Paolo Bonzini , Stefano Stabellini , Igor Mitsyanko , Paul Durrant , Richard Henderson , John Snow Subject: [PATCH v3 14/20] hw/virtio: Let vhost_memory_map() use a boolean 'is_write' argument Date: Thu, 20 Feb 2020 14:05:42 +0100 Message-Id: <20200220130548.29974-15-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200220130548.29974-1-philmd@redhat.com> References: <20200220130548.29974-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org The 'is_write' argument is either 0 or 1. Convert it to a boolean type. Signed-off-by: Philippe Mathieu-Daudé --- hw/virtio/vhost.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 9edfadc81d..0d226dae10 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -294,7 +294,7 @@ static int vhost_dev_has_iommu(struct vhost_dev *dev) } static void *vhost_memory_map(struct vhost_dev *dev, hwaddr addr, - hwaddr *plen, int is_write) + hwaddr *plen, bool is_write) { if (!vhost_dev_has_iommu(dev)) { return cpu_physical_memory_map(addr, plen, is_write); @@ -1012,21 +1012,21 @@ static int vhost_virtqueue_start(struct vhost_dev *dev, vq->desc_size = s = l = virtio_queue_get_desc_size(vdev, idx); vq->desc_phys = a; - vq->desc = vhost_memory_map(dev, a, &l, 0); + vq->desc = vhost_memory_map(dev, a, &l, false); if (!vq->desc || l != s) { r = -ENOMEM; goto fail_alloc_desc; } vq->avail_size = s = l = virtio_queue_get_avail_size(vdev, idx); vq->avail_phys = a = virtio_queue_get_avail_addr(vdev, idx); - vq->avail = vhost_memory_map(dev, a, &l, 0); + vq->avail = vhost_memory_map(dev, a, &l, false); if (!vq->avail || l != s) { r = -ENOMEM; goto fail_alloc_avail; } vq->used_size = s = l = virtio_queue_get_used_size(vdev, idx); vq->used_phys = a = virtio_queue_get_used_addr(vdev, idx); - vq->used = vhost_memory_map(dev, a, &l, 1); + vq->used = vhost_memory_map(dev, a, &l, true); if (!vq->used || l != s) { r = -ENOMEM; goto fail_alloc_used; -- 2.21.1