From: Wolfgang Denk Date: Fri, 21 Feb 2020 17:14:14 +0100 Subject: [PATCH 3/5] env/fat.c: remove private CMD_SAVEENV logic In-Reply-To: <5265fdd5-3992-4e5f-3235-5586b3b77dd7@prevas.dk> References: <20200219094726.26798-1-rasmus.villemoes@prevas.dk> <20200219094726.26798-4-rasmus.villemoes@prevas.dk> <20200219132715.1F81A240036@gemini.denx.de> <5265fdd5-3992-4e5f-3235-5586b3b77dd7@prevas.dk> Message-ID: <20200221161414.CD46924005E@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Rasmus, In message <5265fdd5-3992-4e5f-3235-5586b3b77dd7@prevas.dk> you wrote: > > So without the fat.c patch, CONFIG_SPL_SAVEENV is effectively ignored. OK, but what about bords that don't store the envionment in a file system, but instead for example in (parallel or SPI) NOR flash or in a UBI volume? > Actually, the situation for ext4 is even worse than indicated. ... > Anyway, a side-effect of my ext4 patch is that the above combination > actually builds, because env_ext4_save is not linked in, so hexport_r > isn't needed. And turning on SPL_SAVEENV also works as expected. OK. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de When you die, the first thing you lose is your life. The next thing is the illusions. - Terry Pratchett, _Pyramids_