Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1j6Kej-0000vm-Mx for mharc-qemu-riscv@gnu.org; Mon, 24 Feb 2020 15:48:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48555) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Keg-0000mn-2A for qemu-riscv@nongnu.org; Mon, 24 Feb 2020 15:48:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6Kee-0005zN-H3 for qemu-riscv@nongnu.org; Mon, 24 Feb 2020 15:48:41 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:33573 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6Kee-0005we-Bg for qemu-riscv@nongnu.org; Mon, 24 Feb 2020 15:48:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582577319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FOSoYpbAdepu0uZ7MeetEyTxVfAcL2F73lkW2jHly0I=; b=a9o3pVKmsx2XJYt7JyeUMwbdoP50/JSHeSBM4m4ydv8/2z3u/cVA/H8jWPk/+jpSPGVHcj CzJaXbG3nrU+D3fqMnOiCQt6gjV1zCul+HsEZ5YS99xRUm+GbGP1ASqZMAo9AqT5Jdp8Qd zYyp+EY9Y3X2XP5PC54G1BIN7x21yHI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-215-Wv1ZqOCgMKyg0i9t6VsXqw-1; Mon, 24 Feb 2020 15:48:33 -0500 X-MC-Unique: Wv1ZqOCgMKyg0i9t6VsXqw-1 Received: by mail-wm1-f70.google.com with SMTP id n17so244819wmk.1 for ; Mon, 24 Feb 2020 12:48:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zqh7Kc1FIAfVASZ555lC66r1lz08tHa/s+hlekUQJWc=; b=UXdrW5QLoTYXrDt8D2oZ3oS5wmY7kwu77wWOMKvNbC5f17aq+puIOV6CVqZV/l7DoX e5YlxBVHOFy1GjamAvkb5FIDvRoA12Xg+YFRF0BM8ZbtT/Y4XlYaa8/U/z8wfnqoavBk 9Iucu5oygbj8Bv7l6K0vADo+Tgfq9bQ8Oi+sJMIxhM1tr9xyiEf3XIku34cLXwArvlDd WrvVyW/Fo01gQDbAWAAW7KndIY7bz8jzk47FgfNRGRVgF0jf04ef41PsGIXBQ1GZkn46 0k0VCRvcaMYj+94KLMLo44g10zWpX7iRGd//vMq35WwB8f+4z4bAs+FxpAu+JfaQDMp9 AW6A== X-Gm-Message-State: APjAAAVSfbAIdlLHuIJr8bcV1RBeGoGfTZtFmM+/sX/vbNaxxgpvEmOn gPQhtuH2Y7pcbtmvTKGBGCedeI6zpWMihxx4B02ASo8r6vQmx5IA3jkYqsdmPd/S+PYNNX7svjb 075UURA6AtqKattg= X-Received: by 2002:a7b:c851:: with SMTP id c17mr789414wml.71.1582577312460; Mon, 24 Feb 2020 12:48:32 -0800 (PST) X-Google-Smtp-Source: APXvYqzOAqJ/bsDamXUWT9imGi/21dT+6DCpU6L6WZPE8wurBeFi9b2oLNQpHPLbw9xCpM0fzp7zBw== X-Received: by 2002:a7b:c851:: with SMTP id c17mr789344wml.71.1582577311276; Mon, 24 Feb 2020 12:48:31 -0800 (PST) Received: from x1w.redhat.com (47.red-88-21-205.staticip.rima-tde.net. [88.21.205.47]) by smtp.gmail.com with ESMTPSA id t81sm863436wmg.6.2020.02.24.12.48.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2020 12:48:30 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Paolo Bonzini , qemu-devel@nongnu.org Cc: Joel Stanley , Laurent Vivier , Aleksandar Markovic , Richard Henderson , Andrzej Zaborowski , KONRAD Frederic , Peter Chubb , Palmer Dabbelt , Michael Walle , Max Reitz , "Edgar E. Iglesias" , Marcel Apfelbaum , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , qemu-arm@nongnu.org, Magnus Damm , Subbaraya Sundeep , David Gibson , Eduardo Habkost , Jean-Christophe Dubois , Sagar Karandikar , Igor Mitsyanko , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, Mark Cave-Ayland , Aurelien Jarno , Jason Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Bastian Koppelmann , Fabien Chouteau , Alistair Francis , Kevin Wolf , Aleksandar Rikalo , qemu-block@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Artyom Tarasenko Subject: [PATCH v2 00/32] hw: Sanitize various MemoryRegion uses Date: Mon, 24 Feb 2020 21:47:56 +0100 Message-Id: <20200224204828.23167-1-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Feb 2020 20:48:44 -0000 This series simplifies various memory API calls when creating memory regions. Most of the patches are generated with Coccinelle semantic patches (provided). Few more cleanups added while writting the patches have been added. v1 was 'Let devices own the MemoryRegion they create': https://www.mail-archive.com/qemu-devel@nongnu.org/msg681960.html Since v1: - understood a bit more Peter Maydell comments regarding how memory devices are migrated. Supersedes: <20200221173049.18134-1-philmd@redhat.com> Philippe Mathieu-Daud=C3=A9 (32): memory: Correctly return alias region type memory: Simplify memory_region_init_rom_nomigrate() to ease review scripts/cocci: Rename memory-region-{init-ram -> housekeeping} scripts/cocci: Patch to replace memory_region_init_{ram,readonly -> rom} hw/arm: Use memory_region_init_rom() with read-only regions hw/display: Use memory_region_init_rom() with read-only regions hw/mips: Use memory_region_init_rom() with read-only regions hw/m68k: Use memory_region_init_rom() with read-only regions hw/net: Use memory_region_init_rom() with read-only regions hw/pci-host: Use memory_region_init_rom() with read-only regions hw/ppc: Use memory_region_init_rom() with read-only regions hw/riscv: Use memory_region_init_rom() with read-only regions hw/sh4: Use memory_region_init_rom() with read-only regions hw/sparc: Use memory_region_init_rom() with read-only regions scripts/cocci: Patch to detect potential use of memory_region_init_rom hw/arm/stm32: Use memory_region_init_rom() with read-only regions hw/ppc/ppc405: Use memory_region_init_rom() with read-only regions hw/i386/pc_sysfw: Simplify using memory_region_init_alias() hw/i386/pc_sysfw: Remove unused 'ram_size' argument scripts/cocci: Patch to remove unnecessary memory_region_set_readonly() hw/arm: Remove unnecessary memory_region_set_readonly() on ROM alias scripts/cocci: Patch to let devices own their MemoryRegions hw/arm: Let devices own the MemoryRegion they create hw/char: Let devices own the MemoryRegion they create hw/core: Let devices own the MemoryRegion they create hw/display: Let devices own the MemoryRegion they create hw/dma: Let devices own the MemoryRegion they create hw/riscv: Let devices own the MemoryRegion they create hw/input/milkymist-softusb: Remove unused 'pmem_ptr' field hw/input/milkymist-softusb: Let devices own the MemoryRegion they create hw/net/milkymist-minimac2: Let devices own the MemoryRegion they create hw/block/onenand: Let devices own the MemoryRegion they create .../memory-region-housekeeping.cocci | 159 ++++++++++++++++++ .../coccinelle/memory-region-init-ram.cocci | 38 ----- hw/arm/exynos4210.c | 14 +- hw/arm/fsl-imx25.c | 10 +- hw/arm/fsl-imx31.c | 6 +- hw/arm/fsl-imx6.c | 6 +- hw/arm/fsl-imx6ul.c | 9 +- hw/arm/mainstone.c | 3 +- hw/arm/msf2-soc.c | 6 +- hw/arm/nrf51_soc.c | 2 +- hw/arm/omap_sx1.c | 6 +- hw/arm/palm.c | 3 +- hw/arm/spitz.c | 3 +- hw/arm/stellaris.c | 3 +- hw/arm/stm32f205_soc.c | 11 +- hw/arm/stm32f405_soc.c | 12 +- hw/arm/tosa.c | 3 +- hw/arm/xlnx-zynqmp.c | 11 +- hw/block/onenand.c | 7 +- hw/char/serial.c | 7 +- hw/core/platform-bus.c | 3 +- hw/display/cg3.c | 5 +- hw/display/g364fb.c | 3 +- hw/display/macfb.c | 4 +- hw/display/tcx.c | 5 +- hw/dma/i8257.c | 2 +- hw/dma/rc4030.c | 4 +- hw/i386/pc_sysfw.c | 29 +--- hw/input/milkymist-softusb.c | 12 +- hw/m68k/q800.c | 3 +- hw/mips/mips_fulong2e.c | 3 +- hw/mips/mips_jazz.c | 6 +- hw/mips/mips_mipssim.c | 3 +- hw/mips/mips_r4k.c | 3 +- hw/net/dp8393x.c | 5 +- hw/net/milkymist-minimac2.c | 8 +- hw/pci-host/prep.c | 5 +- hw/ppc/mac_newworld.c | 3 +- hw/ppc/mac_oldworld.c | 3 +- hw/ppc/ppc405_boards.c | 6 +- hw/riscv/sifive_e.c | 9 +- hw/riscv/sifive_u.c | 2 +- hw/sh4/shix.c | 3 +- hw/sparc/leon3.c | 3 +- memory.c | 16 +- MAINTAINERS | 1 + 46 files changed, 268 insertions(+), 200 deletions(-) create mode 100644 scripts/coccinelle/memory-region-housekeeping.cocci delete mode 100644 scripts/coccinelle/memory-region-init-ram.cocci --=20 2.21.1