Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC7B2C3F2CD for ; Fri, 28 Feb 2020 18:18:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A975F246AC for ; Fri, 28 Feb 2020 18:18:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="M3i2rLut" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A975F246AC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4w4TreWvr1lJoKwt/EspfxDj4IPmH3mq5UuQ6OrGgl4=; b=M3i2rLutnA3MKi nLoh22mf27mi8EVXpEkmexSeTHR9quKwX0ant3HA3hYrtOTOJn4aPC03ljcuAEg4gmiGVxi7rjke+ QmQfPQoQLbLv/6eRInKXJBTTMxvp52ypKYiG8tCK3/huzU9l1nijIlRIOUUVcn3F/2y3CwSSWgjHN x+zfwcgWEbKF9iz20Vn+KIc9OKgO2nf9RGuYKtHHQdrJUA1C1FvwvXkzF2hQkYW0aoaiYbyclnoR/ 9t7T0lV3wXjbTpcvYwl7w4fWi8cip+MatHqrMWS5C7arjHeiNvxINq3TyAUZwPu4tr+oBPMRyP3K1 FxPkqwAA2MnvX0Ym3p4w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7kDf-0001AL-8f; Fri, 28 Feb 2020 18:18:39 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7kDc-00019s-Ut for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2020 18:18:38 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B577E31B; Fri, 28 Feb 2020 10:18:35 -0800 (PST) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 152293F7B4; Fri, 28 Feb 2020 10:18:33 -0800 (PST) Date: Fri, 28 Feb 2020 18:18:32 +0000 From: Catalin Marinas To: Amit Daniel Kachhap Subject: Re: [PATCH v5 07/17] arm64: cpufeature: handle conflicts based on capability Message-ID: <20200228181832.GI4019108@arrakis.emea.arm.com> References: <1581931668-11559-1-git-send-email-amit.kachhap@arm.com> <1581931668-11559-8-git-send-email-amit.kachhap@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1581931668-11559-8-git-send-email-amit.kachhap@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200228_101837_040609_FA5D3306 X-CRM114-Status: GOOD ( 11.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Suzuki K Poulose , Kristina Martsenko , Dave Martin , Mark Brown , James Morse , Ramana Radhakrishnan , Vincenzo Frascino , Will Deacon , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 17, 2020 at 02:57:38PM +0530, Amit Daniel Kachhap wrote: > diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h > index 8c80483..1e88aee 100644 > --- a/arch/arm64/include/asm/cpufeature.h > +++ b/arch/arm64/include/asm/cpufeature.h > @@ -352,6 +360,12 @@ cpucap_late_cpu_permitted(const struct arm64_cpu_capabilities *cap) > return !!(cap->type & ARM64_CPUCAP_PERMITTED_FOR_LATE_CPU); > } > > +static inline bool > +cpucap_panic_on_conflict(const struct arm64_cpu_capabilities *cap) > +{ > + return !!(cap->type & ARM64_CPUCAP_PANIC_ON_CONFLICT); > +} Does this need to be in the header file? If not, please move it to cpufeature.c (and drop 'inline' if moved). -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel