Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F8DDC3F2C6 for ; Tue, 3 Mar 2020 08:33:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56A9E20848 for ; Tue, 3 Mar 2020 08:33:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="I/XCBBQw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56A9E20848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CAA77891B4; Tue, 3 Mar 2020 08:33:34 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 95224891B4 for ; Tue, 3 Mar 2020 08:33:33 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id t11so3190442wrw.5 for ; Tue, 03 Mar 2020 00:33:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jGXlJU0eQgCzjZFCDnm9moRkUnZ17jrhoohDk5670JU=; b=I/XCBBQwqf6VpBezJHTFsJ6STmDFRGmhRY71URELCeiKXXJL2nqi8FAS4Wr/h9W6tZ qZSImfhUXhC2LD6T5ixuSKRvE+dzjPGepZafmi/YnQuyR54au5fyeuhADtUikI5Othxy BD8ikK8j9bi1yGdNfU4EqFKp2zz57WKU3ulIc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jGXlJU0eQgCzjZFCDnm9moRkUnZ17jrhoohDk5670JU=; b=Ly4ho1Wm378c2sl/AWmMXy89c2xob48W5WB6IFIR6QECfq1avzrtEQOjDGjVQ3omPa WiN7kz2vn3mXF4X881wpMdVZspMJwbovnmPLmNBmAyaVgOZg/F0EgCJmxqVzpahIKjCl mxjgca2EKroQE2UrcRzG1lbxgZ8VrpGVkzLdgj3EqBPbJDPJVinZ6WgVh2JiM9JUTY97 W9nHmTfD74i5QUwvS1oRDtgc1dOJWHPqa1/XDI6K8rWE+scqgd3ovJZi/phs/aKgim15 qXZbCfi4wwN/V85kS2J2C76RviymfEYUqW/+d2Md2x1FiL7sQICdRtni0q9oLp7jT5Xu 1tXw== X-Gm-Message-State: ANhLgQ0/q1JvcDwezoMlADEt68PLFzURTrhH1I4wgdWrYzDLhdG0eyfR XzW9YzLjmQOD6t1NjxJdeKFqhQ== X-Google-Smtp-Source: ADFU+vuEPs7ifRxsMe24TVGJWfbIbPWvo0MMKCbFY5KzV1I4WqD1iytUS+s1mxvhgCWZC5md8CRBKQ== X-Received: by 2002:a5d:69c6:: with SMTP id s6mr4159063wrw.32.1583224412293; Tue, 03 Mar 2020 00:33:32 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id b197sm2805478wmd.10.2020.03.03.00.33.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2020 00:33:31 -0800 (PST) Date: Tue, 3 Mar 2020 09:33:29 +0100 From: Daniel Vetter To: Thomas Zimmermann Subject: Re: [PATCH] drm/simple-kms: Fix documentation for drm_simple_encoder_init() Message-ID: <20200303083329.GN2363188@phenom.ffwll.local> References: <20200303071807.9288-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200303071807.9288-1-tzimmermann@suse.de> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, sam@ravnborg.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Mar 03, 2020 at 08:18:07AM +0100, Thomas Zimmermann wrote: > Brings the documentation of drm_simple_encoder_init() in sync with the > function's signature. > > Signed-off-by: Thomas Zimmermann > Fixes: 63170ac6f2e8 ("drm/simple-kms: Add drm_simple_encoder_{init,create}()") > Cc: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org > --- > drivers/gpu/drm/drm_simple_kms_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c b/drivers/gpu/drm/drm_simple_kms_helper.c > index 5a2abe2dea3e..2fab80aaf52e 100644 > --- a/drivers/gpu/drm/drm_simple_kms_helper.c > +++ b/drivers/gpu/drm/drm_simple_kms_helper.c > @@ -40,7 +40,7 @@ static const struct drm_encoder_funcs drm_simple_encoder_funcs_cleanup = { > /** > * drm_simple_encoder_init - Initialize a preallocated encoder > * @dev: drm device > - * @funcs: callbacks for this encoder > + * @encoder: the encoder to initialize > * @encoder_type: user visible type of the encoder > * > * Initialises a preallocated encoder that has no further functionality. btw reading this I just realized ... who does the kfree on the memory containing the encoder? The ->destroy hook doesn't do that, and without that the only other option thus far is devm_kzalloc, which is wrong. drmm_kzalloc would fix this, but we don't have that yet. How does this work? Maybe add a FIXME note that right now this can only really be used if the encoder is embedded into something else that's getting freed ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel