Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1j9SgN-0003EP-28 for mharc-grub-devel@gnu.org; Wed, 04 Mar 2020 06:59:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50739) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9SgK-0003CG-R1 for grub-devel@gnu.org; Wed, 04 Mar 2020 06:59:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9SgJ-00039d-Q6 for grub-devel@gnu.org; Wed, 04 Mar 2020 06:59:20 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:49200 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j9SgJ-00038m-Ml for grub-devel@gnu.org; Wed, 04 Mar 2020 06:59:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583323159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YW3r3fPjEG4+0IR8St9GhmljvrwPwl1hyerOi+qkzUA=; b=QSvrH1LnNyxt7Mw9mqlCpcwn7PcL58r0jbH3CmxgDvLhVsbmI7nRh+olb/X039C4Me6MfX cu3FjhE3HgnlKungs28s8FVT2rDlXl+iNH9k3NtUmvqqL4sSxOO+EDmMCKvK07uNdXJ0m1 Q6117jUtjJ6aR8WXfovEdmst4NhIHUY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-28-QF52goOJO4iQNKw7vBTrLQ-1; Wed, 04 Mar 2020 06:59:17 -0500 X-MC-Unique: QF52goOJO4iQNKw7vBTrLQ-1 Received: by mail-wr1-f70.google.com with SMTP id w18so761529wro.2 for ; Wed, 04 Mar 2020 03:59:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0uhV4llCgOzFW/c+9E0/u/MHDvUtgizqSzxSj3PjeGQ=; b=HzYj6FVAHjcbYassEsVm76aTQBjx7DnPyXJPXkpdTRUIvi6emSeB/mzUYkSJkrJReP tNiinXbhiEV0vWWwBmTSU+aWCsSzsYlien+fjh/VjjDBPBV9So/5IgkhgRpRqheShFhE L0ZD2IBjFbscYdgQl+bhslKsufnnLFh2oDwxlFoqBgmo1axTc/XkPIFfCmFfjUn35o5R RjKH+QsYeYYu3UWB9axQzT84CV78vIzyPwTRFSrESN4W/9WhdeAsJTmU6O6n6KdNfIy2 REU/gmxJbcr20XbYYGusZNIV53MLxM9ZaXlDAkOp5E5iEFkNxKJAKgJF6rjeBHOcVnJB x6zQ== X-Gm-Message-State: ANhLgQ1zjb7XGagIryf9/dhgTWg1+Jp20rxa+KPT7Y1qRG/yTgfASCCw HV9KijWbi/gRieyDLV14u+gzd3dIqSV4H4QFhgFcUg9+3B3CSr7Y1cjKb3b5PlkjKiydRqtkDU0 9ov/rUsffJ/o= X-Received: by 2002:a1c:4681:: with SMTP id t123mr3423420wma.69.1583323156529; Wed, 04 Mar 2020 03:59:16 -0800 (PST) X-Google-Smtp-Source: ADFU+vsroLrWQQ0H6I+mLw3g5addbalma38Ph+jkAQBIq5fCYeWdS3WWbpxSlTMjSdTah+nB9ockOw== X-Received: by 2002:a1c:4681:: with SMTP id t123mr3423407wma.69.1583323156337; Wed, 04 Mar 2020 03:59:16 -0800 (PST) Received: from minerva.redhat.com ([2a01:c50f:ab80:6700:527f:85b3:5615:ff0b]) by smtp.gmail.com with ESMTPSA id t14sm5911207wrp.63.2020.03.04.03.59.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 03:59:15 -0800 (PST) From: Javier Martinez Canillas To: grub-devel@gnu.org Cc: Daniel Kiper , Peter Jones , Javier Martinez Canillas Subject: [PATCH v2 02/12] efi: Print more debug info in our module loader Date: Wed, 4 Mar 2020 12:58:41 +0100 Message-Id: <20200304115851.3474263-3-javierm@redhat.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200304115851.3474263-1-javierm@redhat.com> References: <20200304115851.3474263-1-javierm@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2020 11:59:21 -0000 From: Peter Jones The function that searches the mods section base address does not have any debug information. Add some debugging outputs that could be useful. Signed-off-by: Peter Jones Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Kiper --- grub-core/kern/efi/efi.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/grub-core/kern/efi/efi.c b/grub-core/kern/efi/efi.c index 6e1ceb90516..3a708ed7215 100644 --- a/grub-core/kern/efi/efi.c +++ b/grub-core/kern/efi/efi.c @@ -308,13 +308,23 @@ grub_efi_modules_addr (void) } =20 if (i =3D=3D coff_header->num_sections) - return 0; + { + grub_dprintf("sections", "section %d is last section; invalid.\n", i= ); + return 0; + } =20 info =3D (struct grub_module_info *) ((char *) image->image_base =09=09=09=09 + section->virtual_address); - if (info->magic !=3D GRUB_MODULE_MAGIC) - return 0; + if (section->name[0] !=3D '.' && info->magic !=3D GRUB_MODULE_MAGIC) + { + grub_dprintf("sections", +=09=09 "section %d has bad magic %08x, should be %08x\n", +=09=09 i, info->magic, GRUB_MODULE_MAGIC); + return 0; + } =20 + grub_dprintf("sections", "returning section info for section %d: \"%s\"\= n", +=09 i, section->name); return (grub_addr_t) info; } =20 --=20 2.24.1