Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1j9SgP-0003LY-Vl for mharc-grub-devel@gnu.org; Wed, 04 Mar 2020 06:59:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50759) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9SgN-0003Er-5v for grub-devel@gnu.org; Wed, 04 Mar 2020 06:59:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9SgL-0003C2-Lu for grub-devel@gnu.org; Wed, 04 Mar 2020 06:59:23 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:40069 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j9SgL-0003Bb-I4 for grub-devel@gnu.org; Wed, 04 Mar 2020 06:59:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583323161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GNfRUbvB1M91A7881jV1TeW655o1WzYcPB4qPqIrr9g=; b=XzbGy+LXaDJErCZzkwrnkxnWoQdjfrFBkPIXOIVjkuENh/g8/Jd/H36cmPYqS98PWpksKe lA0mtBITrJ0l9e6MKLGkQI643bia5H3SbCbl/7dVYuQ+JrB2uhkScLezEgIxw+q7gOBpdp XSh5jsyOpBerhEKVC4rkmfCTgoYsXqk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-372-XW6Nw4ElOEKGkMPuLUk3Kw-1; Wed, 04 Mar 2020 06:59:20 -0500 X-MC-Unique: XW6Nw4ElOEKGkMPuLUk3Kw-1 Received: by mail-wm1-f71.google.com with SMTP id b67so451834wmb.8 for ; Wed, 04 Mar 2020 03:59:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gNK1RXLGrpwPxRrDmc9XHbBSwHbOvVBJCX2jU4zKIfY=; b=UbvS28HZlNoqdWqnqz1q2rUXrl0hnW/VwtIZK/nCA86F3/gWPCOfI6eFaOiIL8CE7K DbW6KBZcJWPg5xVDJc+bu+Fyju87JRJ8eeF16lGZ3Kp0R5sBj8I6biWWa402lCSNgKPa 9KjLDFyKJEE8rmvtha8K01qqI432UTV8so/H2UGDLPDAHkKL3mKARjF7AETZKVkKKslh p167j5fTmZKFH8nVCwH3n2MYfnSPuVe67wlgrcCauReRD+t8KtGAsguWf/RAVj3iyjH+ rHfWj9vtRcT4aIoBMJnYd2cGBzaw9V+drFfYMDsy39Lmldi/e8wcwVBG91l5ZeYdOuRY ZqkQ== X-Gm-Message-State: ANhLgQ0fsXMc+lIJS5rNrKlWS5D2XDy/yY9BRxwLI+8uvMx+ghu+ecBE qx3fdbx/qP5pAPrU49JtObChEmlRtHHMp7ATGDeUHy4zK5BJpUzZf5rsEmCOpdjRSOmqDJhHyxE CBeI4lEiQdiU= X-Received: by 2002:adf:f584:: with SMTP id f4mr1847055wro.77.1583323158153; Wed, 04 Mar 2020 03:59:18 -0800 (PST) X-Google-Smtp-Source: ADFU+vt4xjrCH0GCEnPmc5J2AI7JekrG0IgZDbnponZK8oMhRgloSWpQJt3lYf76KoVXeJpFyhTYJQ== X-Received: by 2002:adf:f584:: with SMTP id f4mr1847036wro.77.1583323157858; Wed, 04 Mar 2020 03:59:17 -0800 (PST) Received: from minerva.redhat.com ([2a01:c50f:ab80:6700:527f:85b3:5615:ff0b]) by smtp.gmail.com with ESMTPSA id t14sm5911207wrp.63.2020.03.04.03.59.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 03:59:17 -0800 (PST) From: Javier Martinez Canillas To: grub-devel@gnu.org Cc: Daniel Kiper , Peter Jones , Javier Martinez Canillas Subject: [PATCH v2 03/12] Makefile: Make libgrub.pp depend on config-util.h Date: Wed, 4 Mar 2020 12:58:42 +0100 Message-Id: <20200304115851.3474263-4-javierm@redhat.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200304115851.3474263-1-javierm@redhat.com> References: <20200304115851.3474263-1-javierm@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2020 11:59:25 -0000 From: Peter Jones If you build with "make -j48" a lot, sometimes you see: gcc -E -DHAVE_CONFIG_H -I. -I.. -Wall -W -DGRUB_UTIL=3D1 -D_FILE_OFFSET_BI= TS=3D64 -I./include -DGRUB_FILE=3D\"grub_script.tab.h\" -I. -I.. -I. -I.. -= I../include -I./include -I../grub-core/lib/libgcrypt-grub/src/ -I../grub-c= ore/lib/minilzo -I../grub-core/lib/xzembed -DMINILZO_HAVE_CONFIG_H -Wall -W= -DGRUB_UTIL=3D1 -D_FILE_OFFSET_BITS=3D64 -I./include -DGRUB_FILE=3D\"grub_= script.tab.h\" -I. -I.. -I. -I.. -I../include -I./include -I../grub-core/li= b/libgcrypt-grub/src/ -I./grub-core/gnulib -I../grub-core/gnulib -I/buildd= ir/build/BUILD/grub-2.02/grub-aarch64-efi-2.02 -D_FILE_OFFSET_BITS=3D64 \ -D'GRUB_MOD_INIT(x)=3D@MARKER@x@' grub_script.tab.h grub_script.yy.h ../g= rub-core/commands/blocklist.c ../grub-core/commands/macbless.c ../grub-core= /commands/xnu_uuid.c ../grub-core/commands/testload.c ../grub-core/commands= /ls.c ../grub-core/disk/dmraid_nvidia.c ../grub-core/disk/loopback.c ../gru= b-core/disk/lvm.c ../grub-core/disk/mdraid_linux.c ../grub-core/disk/mdraid= _linux_be.c ../grub-core/disk/mdraid1x_linux.c ../grub-core/disk/raid5_reco= ver.c ../grub-core/disk/raid6_recover.c ../grub-core/font/font.c ../grub-co= re/gfxmenu/font.c ../grub-core/normal/charset.c ../grub-core/video/fb/fbbli= t.c ../grub-core/video/fb/fbutil.c ../grub-core/video/fb/fbfill.c ../grub-c= ore/video/fb/video_fb.c ../grub-core/video/video.c ../grub-core/video/captu= re.c ../grub-core/video/colors.c ../grub-core/unidata.c ../grub-core/io/buf= io.c ../grub-core/fs/affs.c ../grub-core/fs/afs.c ../grub-core/fs/bfs.c ../= grub-core/fs/btrfs.c ../grub-core/fs/cbfs.c ../grub-core/fs/cpio.c ../grub-= core/fs/cpio_be.c ../grub-core/fs/odc.c ../grub-core/fs/newc.c ../grub-core= /fs/ext2.c ../grub-core/fs/fat.c ../grub-core/fs/exfat.c ../grub-core/fs/fs= help.c ../grub-core/fs/hfs.c ../grub-core/fs/hfsplus.c ../grub-core/fs/hfsp= luscomp.c ../grub-core/fs/iso9660.c ../grub-core/fs/jfs.c ../grub-core/fs/m= inix.c ../grub-core/fs/minix2.c ../grub-core/fs/minix3.c ../grub-core/fs/mi= nix_be.c ../grub-core/fs/minix2_be.c ../grub-core/fs/minix3_be.c ../grub-co= re/fs/nilfs2.c ../grub-core/fs/ntfs.c ../grub-core/fs/ntfscomp.c ../grub-co= re/fs/reiserfs.c ../grub-core/fs/romfs.c ../grub-core/fs/sfs.c ../grub-core= /fs/squash4.c ../grub-core/fs/tar.c ../grub-core/fs/udf.c ../grub-core/fs/u= fs2.c ../grub-core/fs/ufs.c ../grub-core/fs/ufs_be.c ../grub-core/fs/xfs.c = ../grub-core/fs/zfs/zfscrypt.c ../grub-core/fs/zfs/zfs.c ../grub-core/fs/zf= s/zfsinfo.c ../grub-core/fs/zfs/zfs_lzjb.c ../grub-core/fs/zfs/zfs_lz4.c ..= /grub-core/fs/zfs/zfs_sha256.c ../grub-core/fs/zfs/zfs_fletcher.c ../grub-c= ore/lib/envblk.c ../grub-core/lib/hexdump.c ../grub-core/lib/LzFind.c ../gr= ub-core/lib/LzmaEnc.c ../grub-core/lib/crc.c ../grub-core/lib/adler32.c ../= grub-core/lib/crc64.c ../grub-core/normal/datetime.c ../grub-core/normal/mi= sc.c ../grub-core/partmap/acorn.c ../grub-core/partmap/amiga.c ../grub-core= /partmap/apple.c ../grub-core/partmap/sun.c ../grub-core/partmap/plan.c ../= grub-core/partmap/dvh.c ../grub-core/partmap/sunpc.c ../grub-core/partmap/b= sdlabel.c ../grub-core/partmap/dfly.c ../grub-core/script/function.c ../gru= b-core/script/lexer.c ../grub-core/script/main.c ../grub-core/script/script= .c ../grub-core/script/argv.c ../grub-core/io/gzio.c ../grub-core/io/xzio.c= ../grub-core/io/lzopio.c ../grub-core/kern/ia64/dl_helper.c ../grub-core/k= ern/arm/dl_helper.c ../grub-core/kern/arm64/dl_helper.c ../grub-core/lib/mi= nilzo/minilzo.c ../grub-core/lib/xzembed/xz_dec_bcj.c ../grub-core/lib/xzem= bed/xz_dec_lzma2.c ../grub-core/lib/xzembed/xz_dec_stream.c ../util/misc.c = ../grub-core/kern/command.c ../grub-core/kern/device.c ../grub-core/kern/di= sk.c ../grub-core/lib/disk.c ../util/getroot.c ../grub-core/osdep/unix/getr= oot.c ../grub-core/osdep/getroot.c ../grub-core/osdep/devmapper/getroot.c .= ./grub-core/osdep/relpath.c ../grub-core/kern/emu/hostdisk.c ../grub-core/o= sdep/devmapper/hostdisk.c ../grub-core/osdep/hostdisk.c ../grub-core/osdep/= unix/hostdisk.c ../grub-core/osdep/exec.c ../grub-core/osdep/sleep.c ../gru= b-core/osdep/password.c ../grub-core/kern/emu/misc.c ../grub-core/kern/emu/= mm.c ../grub-core/kern/env.c ../grub-core/kern/err.c ../grub-core/kern/file= .c ../grub-core/kern/fs.c ../grub-core/kern/list.c ../grub-core/kern/misc.c= ../grub-core/kern/partition.c ../grub-core/lib/crypto.c ../grub-core/disk/= luks.c ../grub-core/disk/geli.c ../grub-core/disk/cryptodisk.c ../grub-core= /disk/AFSplitter.c ../grub-core/lib/pbkdf2.c ../grub-core/commands/extcmd.c= ../grub-core/lib/arg.c ../grub-core/disk/ldm.c ../grub-core/disk/diskfilte= r.c ../grub-core/partmap/gpt.c ../grub-core/partmap/msdos.c ../grub-core/fs= /proc.c ../grub-core/fs/archelp.c > libgrub.pp || (rm -f libgrub.pp; exit 1= ) rm -f stamp-h1 touch ../config-util.h.in cd . && /bin/sh ./config.status config-util.h config.status: creating config-util.h In file included from ../include/grub/mm.h:25:0, from ../include/grub/disk.h:29, from ../include/grub/file.h:26, from ../grub-core/fs/btrfs.c:21: ./config.h:38:10: fatal error: ./config-util.h: No such file or directory #include ^~~~~~~~~~~~~~~ compilation terminated. make: *** [Makefile:13098: libgrub.pp] Error 1 This is because libgrub.pp is built with -DGRUB_UTIL=3D1, which means it'll try to include config-util.h, but a parallel make is actually building that file. I think. Signed-off-by: Peter Jones Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Kiper --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 1f4bb9b8c5a..bf9c1ba64c9 100644 --- a/Makefile.am +++ b/Makefile.am @@ -37,7 +37,7 @@ grub_script.yy.c: grub_script.yy.h CLEANFILES +=3D grub_script.yy.c grub_script.yy.h =20 # For libgrub.a -libgrub.pp: grub_script.tab.h grub_script.yy.h $(libgrubmods_a_SOURCES) $(= libgrubkern_a_SOURCES) +libgrub.pp: config-util.h grub_script.tab.h grub_script.yy.h $(libgrubmods= _a_SOURCES) $(libgrubkern_a_SOURCES) =09$(CPP) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(libgrubmods_a_CPPFLAGS= ) $(libgrubkern_a_CPPFLAGS) $(CPPFLAGS) \ =09 -D'GRUB_MOD_INIT(x)=3D@MARKER@x@' $^ > $@ || (rm -f $@; exit 1) CLEANFILES +=3D libgrub.pp --=20 2.24.1