Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1j9SgT-0003S5-1l for mharc-grub-devel@gnu.org; Wed, 04 Mar 2020 06:59:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50787) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9SgP-0003K0-6w for grub-devel@gnu.org; Wed, 04 Mar 2020 06:59:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9SgO-0003DM-AZ for grub-devel@gnu.org; Wed, 04 Mar 2020 06:59:25 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:20434 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j9SgO-0003DG-6O for grub-devel@gnu.org; Wed, 04 Mar 2020 06:59:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583323163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iOrS44SfiwyP/WozF07IdpyPp1d7pUPk7LhQbCxMfug=; b=ckTvklKZYkWHEVx+uRkq73EX/nuej6ACWoi39+RGrlPr3YHMcuwiLty8bXKFGB3C3+7k2O NcaubkEjYbgso8NgKEsCjzGnfckRdBs9EMZGkrRfEpJ61iDVLZUZRFC3VtxPVh5VZQ09RA CJIxC1y3RrFvOyyD0ukY6uI7Tz4eOlc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-82-YWffDcNtNh2KZ8jIrsSPxQ-1; Wed, 04 Mar 2020 06:59:22 -0500 X-MC-Unique: YWffDcNtNh2KZ8jIrsSPxQ-1 Received: by mail-wr1-f71.google.com with SMTP id n12so736378wrp.19 for ; Wed, 04 Mar 2020 03:59:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HDbdzrvTh2dNu46sG6ohO1G5xaQP/utdzdwTpvCNTTw=; b=RGfsup8KXVBlutpjf/0UzTzB8jL/sfAyJ8kLCc4UEWhjEm8Hkg0JPMTQHH4QoLzWqu JCflDtyjqejFRdsOQuU9+HR8aORuVwI+H5vANjgdVDcEI4M2Q5ZW5KrFx302hHrpwRyV b+0CcFT9EPFhfz6RPfl2Ru87wq8yOXtog1CEIzI8QQArHj58peN6eAtzzefV4+r8MiLO rl8P8t+upl6lEjgYn0w6rWpoCEpUkUdR4rAajRowd/dzl2wHOOAMkRFsMb4HEKrDOFLs RYc/PtW6PWImOhyWGzTdw+9jL5GDBZQU5DmxguzdjqpbwK7cvyZvvTXswmMR3ybGgx05 Vkyg== X-Gm-Message-State: ANhLgQ0qWGNbIQp8kS1cPHfC/Ev6JOxy7tMlaVcuBX6/SMSpxL9RJsMc olZDP+OtoaiqGsC7TXVWE6MMNslpHOHZeMz/r12o9QCkNjFE6gY2hTwDHnnKP7vg/y5klHUvTP3 wOtAvo9Bkewc= X-Received: by 2002:a5d:4a41:: with SMTP id v1mr3877090wrs.205.1583323160500; Wed, 04 Mar 2020 03:59:20 -0800 (PST) X-Google-Smtp-Source: ADFU+vtc+HahZbtMkZOmqcmGiWLMRH24TfD8eTMzSUENKiwjXfucebNEHlgX3XMOMMpGBQb8oDAQRg== X-Received: by 2002:a5d:4a41:: with SMTP id v1mr3877075wrs.205.1583323160272; Wed, 04 Mar 2020 03:59:20 -0800 (PST) Received: from minerva.redhat.com ([2a01:c50f:ab80:6700:527f:85b3:5615:ff0b]) by smtp.gmail.com with ESMTPSA id t14sm5911207wrp.63.2020.03.04.03.59.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 03:59:19 -0800 (PST) From: Javier Martinez Canillas To: grub-devel@gnu.org Cc: Daniel Kiper , Peter Jones , Javier Martinez Canillas Subject: [PATCH v2 05/12] normal/completion: Fix possible NULL pointer dereference Date: Wed, 4 Mar 2020 12:58:44 +0100 Message-Id: <20200304115851.3474263-6-javierm@redhat.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200304115851.3474263-1-javierm@redhat.com> References: <20200304115851.3474263-1-javierm@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2020 11:59:26 -0000 From: Peter Jones Coverity Scan reports that the grub_strrchr() function can return NULL if the character is not found. Check if that's the case for dirfile pointer. Signed-off-by: Peter Jones Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Kiper --- grub-core/normal/completion.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/grub-core/normal/completion.c b/grub-core/normal/completion.c index 596102848c1..c07100a8de3 100644 --- a/grub-core/normal/completion.c +++ b/grub-core/normal/completion.c @@ -284,7 +284,8 @@ complete_file (void) =20 /* Cut away the filename part. */ dirfile =3D grub_strrchr (dir, '/'); - dirfile[1] =3D '\0'; + if (dirfile) +=09dirfile[1] =3D '\0'; =20 /* Iterate the directory. */ (fs->fs_dir) (dev, dir, iterate_dir, NULL); --=20 2.24.1