From: Christoph Hellwig Subject: Re: [PATCH v6 1/6] pmem: Add functions for reading/writing page to/from pmem Date: Wed, 4 Mar 2020 08:16:37 -0800 Message-ID: <20200304161637.GA16390@infradead.org> References: <20200228163456.1587-1-vgoyal@redhat.com> <20200228163456.1587-2-vgoyal@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org To: Pankaj Gupta Cc: Vivek Goyal , linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, hch@infradead.org, dan.j.williams@intel.com, david@fromorbit.com, dm-devel@redhat.com, Christoph Hellwig List-Id: dm-devel.ids On Sat, Feb 29, 2020 at 09:04:00AM +0100, Pankaj Gupta wrote: > > + phys_addr_t pmem_off = sector * 512 + pmem->data_offset; > > minor nit, maybe 512 is replaced by macro? Looks like its used at multiple > places, maybe can keep at is for now. That would be the existing SECTOR_SIZE macro.