Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1j9qrr-0005EO-I6 for mharc-qemu-trivial@gnu.org; Thu, 05 Mar 2020 08:48:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54637) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9qrl-0005Dv-6q for qemu-trivial@nongnu.org; Thu, 05 Mar 2020 08:48:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9qrk-0007Qd-8d for qemu-trivial@nongnu.org; Thu, 05 Mar 2020 08:48:45 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:46600 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j9qrk-0007Os-5E for qemu-trivial@nongnu.org; Thu, 05 Mar 2020 08:48:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583416123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8+VnPHXCdM1ruYsfahkKpY3F2lvog7w+FsvLfaWX0XU=; b=Ir6GQ3tBAnHZ3Ts/+7Az3LwsN9Ro1nbf6nAapRIP2wUlYk/8YdiSE6ZpZbIj5Ywbo2MSfa 5LsgNsp5NHDZetIynFDE9K89tsVuI7LX/arj8eASrYAD0J+fGYJvQu8XEdvtNj7uiN6zhi KwfTD5y8a2t7iAIukNBRad9StFzyn5w= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-132-8IFMk3h1MVm75Gv8U_5rNA-1; Thu, 05 Mar 2020 08:48:42 -0500 X-MC-Unique: 8IFMk3h1MVm75Gv8U_5rNA-1 Received: by mail-wr1-f69.google.com with SMTP id z16so2316960wrm.15 for ; Thu, 05 Mar 2020 05:48:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=gsyUyUPltOyaG0CmvFZxAKR3eWI6lV29vRJfoKAg7FY=; b=YgnTJ9/5rKGRjMCNAXPcDdIyNkI7NUe4SPjOznElq9ORN47+pA+8uEkqSdCusLlru+ MmezBUE+kTQqjkkHSNVtQxodJPlUTuFbI+DaVHIMMI2uA9MSdFzzaUODWZtmI20ftv9G zUvRQf0YjegPESg+LtvdUa7Hdm2NTpvQaqaa6t5GzccIcebJ6Tw5HWrsi06iE4wOw+H8 HMMSRYM4lzP+PZ15cTLf+tHbd0Jdxqq3gM8Bpf9t9usxbQvhdiDqe9xLB/+AAwFy/R9x dKQGZy4iDZtQFifPUe0XXMgwUAkkHLeqvmEu41IeNw0YzNwTXWgqT4+6yWpUyrlWRGDf TT1w== X-Gm-Message-State: ANhLgQ232V9odWVvRdgonzFG76KaNzKth0kjHjYtzimAUgZ+/mJ2xtBY XnIICJQLqO/E3WjgiZm1wbQsWCqRcMIeWzaeJhI3LYmUthawW/aoGjlI9UAy28lB+6CNW53B62b +fFC20lzPG6Y8ume91A== X-Received: by 2002:a1c:e918:: with SMTP id q24mr9746990wmc.25.1583416120189; Thu, 05 Mar 2020 05:48:40 -0800 (PST) X-Google-Smtp-Source: ADFU+vunHM2fYLPgoBLdmfHItq7ipps+5rkO04vueG8TBu6BNNdR8Pt2a8eBdF2X2/cHR0yHgWG9NQ== X-Received: by 2002:a1c:e918:: with SMTP id q24mr9746964wmc.25.1583416119933; Thu, 05 Mar 2020 05:48:39 -0800 (PST) Received: from steredhat (host34-204-dynamic.43-79-r.retail.telecomitalia.it. [79.43.204.34]) by smtp.gmail.com with ESMTPSA id o8sm8923043wmh.15.2020.03.05.05.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2020 05:48:39 -0800 (PST) Date: Thu, 5 Mar 2020 14:48:37 +0100 From: Stefano Garzarella To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Jason Wang , Gerd Hoffmann , Christian Schoenebeck , Greg Kurz , Dmitry Fleytman Subject: Re: [PATCH v2 2/9] hw/audio/fmopl: Move ENV_CURVE to .heap to save 32KiB of .bss Message-ID: <20200305134837.ucdb6blcguyfrh6d@steredhat> References: <20200305124525.14555-1-philmd@redhat.com> <20200305124525.14555-3-philmd@redhat.com> <20200305134403.sagzdlf5iyk2iufs@steredhat> MIME-Version: 1.0 In-Reply-To: <20200305134403.sagzdlf5iyk2iufs@steredhat> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Mar 2020 13:48:46 -0000 On Thu, Mar 05, 2020 at 02:44:03PM +0100, Stefano Garzarella wrote: > On Thu, Mar 05, 2020 at 01:45:18PM +0100, Philippe Mathieu-Daud=E9 wrote: > > This buffer is only used by the adlib audio device. Move it to > > the .heap to release 32KiB of .bss (size reported on x86_64 host). > >=20 > > Signed-off-by: Philippe Mathieu-Daud=E9 > > --- > > hw/audio/fmopl.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > >=20 > > diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c > > index 173a7521f2..356d4dfbca 100644 > > --- a/hw/audio/fmopl.c > > +++ b/hw/audio/fmopl.c > > @@ -186,7 +186,7 @@ static int32_t *VIB_TABLE; > > =20 > > /* envelope output curve table */ > > /* attack + decay + OFF */ > > -static int32_t ENV_CURVE[2*EG_ENT+1]; > > +static int32_t *ENV_CURVE; > > =20 > > /* multiple table */ > > #define ML 2 > > @@ -1090,6 +1090,7 @@ FM_OPL *OPLCreate(int clock, int rate) > > =09OPL->clock =3D clock; > > =09OPL->rate =3D rate; > > =09OPL->max_ch =3D max_ch; > > + ENV_CURVE =3D g_new(int32_t, 2 * EG_ENT + 1); Should we use g_new0() ? > > =09/* init grobal tables */ > > =09OPL_initialize(OPL); > > =09/* reset chip */ > > @@ -1127,6 +1128,7 @@ void OPLDestroy(FM_OPL *OPL) > > #endif > > =09OPL_UnLockTable(); > > =09free(OPL); > > + g_free(ENV_CURVE); >=20 > Just for curiosity, here the entire fmopl.c is indented with tabs. >=20 > In this case, is it better to continue with the tabs or use spaces > for new changes? >=20 > Anyway the changes LGTM: > Reviewed-by: Stefano Garzarella