Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83DFFC3F2D1 for ; Thu, 5 Mar 2020 13:45:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33B5D2073D for ; Thu, 5 Mar 2020 13:45:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nic.cz header.i=@nic.cz header.b="iATxvOSj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726162AbgCENpk (ORCPT ); Thu, 5 Mar 2020 08:45:40 -0500 Received: from lists.nic.cz ([217.31.204.67]:43160 "EHLO mail.nic.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbgCENpk (ORCPT ); Thu, 5 Mar 2020 08:45:40 -0500 X-Greylist: delayed 407 seconds by postgrey-1.27 at vger.kernel.org; Thu, 05 Mar 2020 08:45:39 EST Received: from localhost (unknown [172.20.6.135]) by mail.nic.cz (Postfix) with ESMTPSA id BE801141A93; Thu, 5 Mar 2020 14:38:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1583415531; bh=y15riXJR+DrsdwVlJxdS/SkxKUiC5pZ9UVOEQ78qD+k=; h=Date:From:To; b=iATxvOSjFfe5jxvs8hkEgBDU+5LYrv7Dt1cxrk2vusDnRZmMGW5GRqRtRu2tZauK5 54U18C1ldqZWJjIGLnMYwAdamh3fWGqz1v9KfInN3zTsI/LoAAf/DcQlBWxwhH77Qr 5SQJEXIlvtoC3ReaMiN0RAyH7RgSvx/Ed5M+2fE0= Date: Thu, 5 Mar 2020 14:38:47 +0100 From: Marek Behun To: Russell King Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org, Vivien Didelot Subject: Re: [PATCH net-next 06/10] net: dsa: mv88e6xxx: extend phylink to Serdes PHYs Message-ID: <20200305143847.6507e32b@nic.cz> In-Reply-To: References: <20200305124139.GB25745@shell.armlinux.org.uk> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.101.4 at mail X-Virus-Status: Clean Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 05 Mar 2020 12:42:31 +0000 Russell King wrote: > +int mv88e6390_serdes_pcs_link_up(struct mv88e6xxx_chip *chip, int port, > + u8 lane, int speed, int duplex) > +{ > + u16 val, bmcr; > + int err; > + > + err = mv88e6390_serdes_read(chip, lane, MDIO_MMD_PHYXS, > + MV88E6390_SGMII_BMCR, &val); > + if (err) > + return err; > + > + bmcr = val & ~(BMCR_SPEED100 | BMCR_FULLDPLX | BMCR_SPEED1000); > + switch (speed) { > + case SPEED_2500: > + case SPEED_1000: > + bmcr |= BMCR_SPEED1000; > break; > - case MV88E6XXX_PORT_STS_CMODE_1000BASEX: > - mode = PHY_INTERFACE_MODE_1000BASEX; > + case SPEED_100: > + bmcr |= BMCR_SPEED100; > break; > - case MV88E6XXX_PORT_STS_CMODE_2500BASEX: > - mode = PHY_INTERFACE_MODE_2500BASEX; > + case SPEED_10: > break; > - default: > - mode = PHY_INTERFACE_MODE_NA; > } > > - err = mv88e6xxx_port_setup_mac(chip, port, link, speed, duplex, > - PAUSE_OFF, mode); > - if (err) > - dev_err(chip->dev, "can't propagate PHY settings to MAC: %d\n", > - err); > - else > - dsa_port_phylink_mac_change(ds, port, link == LINK_FORCED_UP); > + if (duplex == DUPLEX_FULL) > + bmcr |= BMCR_FULLDPLX; > + > + if (bmcr == val) > + return 0; > + > + return mv88e6390_serdes_write(chip, lane, MDIO_MMD_PHYXS, > + MV88E6390_SGMII_BMCR, bmcr); > +} Hi, some time ago I wondered if it would make sense to separate the SERDES PHY code into a separate phy driver to reside in drivers/net/phy/marvell-serdes.c or something like that. Are there compatible PHYs which aren't integrated into a switch? Marek