Content-Type: multipart/mixed; boundary="===============6904576814267344940=="
MIME-Version: 1.0
From: Peter Xu <peterx@redhat.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v5 05/14] KVM: X86: Implement ring-based dirty memory tracking
Date: Mon, 09 Mar 2020 17:35:54 -0400
Message-ID: <20200309213554.GF4206@xz-x1>
In-Reply-To: <202003061911.MfG74mgX%lkp@intel.com>
List-Id: <oe-kbuild-all.lists.linux.dev>

--===============6904576814267344940==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 06, 2020 at 07:32:20PM +0800, kbuild test robot wrote:
> Hi Peter,
> =

> Thank you for the patch! Yet something to improve:
> =

> [auto build test ERROR on tip/auto-latest]
> [also build test ERROR on linus/master v5.6-rc4]
> [cannot apply to kvm/linux-next linux/master vhost/linux-next next-202003=
05]
> [if your patch is applied to the wrong git tree, please drop us a note to=
 help
> improve the system. BTW, we also suggest to use '--base' option to specif=
y the
> base tree in git format-patch, please see https://stackoverflow.com/a/374=
06982]
> =

> url:    https://github.com/0day-ci/linux/commits/Peter-Xu/KVM-Dirty-ring-=
interface/20200305-053531
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 6f2bc=
932d8ff72b1a0a5c66f3dad04ccba576a8b
> config: s390-alldefconfig (attached as .config)
> compiler: s390-linux-gcc (GCC) 7.5.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi=
n/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         GCC_VERSION=3D7.5.0 make.cross ARCH=3Ds390 =

> =

> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> =

> All errors (new ones prefixed by >>):
> =

>    arch/s390/../../virt/kvm/kvm_main.o: In function `kvm_reset_dirty_gfn':
> >> kvm_main.c:(.text+0x6a60): undefined reference to `kvm_arch_mmu_enable=
_log_dirty_pt_masked'

It turns out that when I wanted to fix the build error previously, I
did the compilation test (using a ppc64 host) without using the
correct config file, so KVM is not enabled at all...

I'll fix it (again) this time by moving kvm_reset_dirty_gfn() into
kvm_dirty_ring.c (and some other macro touch-ups).  I'll probably also
move KVM_DIRTY_LOG_PAGE_OFFSET=3D=3D0 definition to uapi/linux/kvm.h.

Thanks,

-- =

Peter Xu

--===============6904576814267344940==--