Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD09FC10F25 for ; Tue, 10 Mar 2020 00:06:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 997B424655 for ; Tue, 10 Mar 2020 00:06:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="BsFV47Wd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727539AbgCJAG1 (ORCPT ); Mon, 9 Mar 2020 20:06:27 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:34644 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727526AbgCJAG1 (ORCPT ); Mon, 9 Mar 2020 20:06:27 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 583255F; Tue, 10 Mar 2020 01:06:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1583798785; bh=1IEHTZRCHupzO3PZvOxuRYzfscWLvRVoD0MzAtB/cRk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BsFV47WdmO++6oN9xmx96GObNCRThBdu4Xw9UwE6JG8rz+LLe0KErksZ/t734ggZk 0cY1UWptvsbxiyr9j2QVq43LP6F1ig9i4S5P7MmUOCqAMUSXiCkXXM2Er5L/qNItXn WzHhy1txc/pOumdclv1XibAyZwddRchdbxdeCTZY= Date: Tue, 10 Mar 2020 02:06:22 +0200 From: Laurent Pinchart To: Steve Longerbeam Cc: linux-media@vger.kernel.org, Philipp Zabel , Rui Miguel Silva Subject: Re: [PATCH 7/7] media: imx: imx7-media-csi: Fix video field handling Message-ID: <20200310000622.GK4916@pendragon.ideasonboard.com> References: <20191024004155.32068-1-laurent.pinchart@ideasonboard.com> <20191024004155.32068-8-laurent.pinchart@ideasonboard.com> <3d979bfa-0bb2-0dde-9bc7-83ee3923d33a@gmail.com> <20200309205238.GH4916@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Steve, On Mon, Mar 09, 2020 at 05:00:02PM -0700, Steve Longerbeam wrote: > On 3/9/20 1:52 PM, Laurent Pinchart wrote: > > On Thu, Oct 24, 2019 at 08:11:20AM -0700, Steve Longerbeam wrote: > >> On 10/23/19 5:41 PM, Laurent Pinchart wrote: > >>> Commit 4791bd7d6adc ("media: imx: Try colorimetry at both sink and > >>> source pads") reworked the way that formats are set on the sink pad of > >>> the CSI subdevice, and accidentally removed video field handling. > > > >> Well, let me restate the problem. This driver never did have correct > >> field handling (as you demonstrate in this patch, the driver never > >> set/propagated the field type to its source pad). So it's not accurate > >> to say the patch is a fix. A better description is that it adds > >> rudimentary field handling. > > > > Didn't it ? The above commit removed a call to > > imx_media_fill_default_mbus_fields() from imx7_csi_try_fmt(), and that > > function had rudimentary field handling. The Fixes: tag isn't there to > > blame you :-) > > Sorry, you're right, 4791bd7d6adc should have placed some sane field > value back at sink pad in imx7_csi_try_fmt(). But the problem is that at > the time, I didn't know what a sane field value for imx7 would be (your > patch resolved that question, by stating only NONE and INTERLACED are > supported). But I must stand by my statement that field was never > propagated to source. I guess I was waiting for someone to implement > basic field handling, instead of possibly doing the wrong thing myself. > I should have clarified at the time that there needed to be basic field > handling added. We all know there's a bit of work needed on this driver :-) Hence the staging status. I'll post a v2 of this series, and additional patches will follow. I will likely not address interlaced support though, as I have no system to test that on, but you can expect improvements for the rest of the code, especially the parts used with CSI-2 sensors. > >>> Restore it by defaulting to V4L2_FIELD_NONE if the field value isn't > >>> supported, with the only two supported value being V4L2_FIELD_NONE and > >>> V4L2_FIELD_ALTERNATE. > >>> > >>> Fixes: 4791bd7d6adc ("media: imx: Try colorimetry at both sink and source pads") > >>> Signed-off-by: Laurent Pinchart > >>> --- > >>> drivers/staging/media/imx/imx7-media-csi.c | 4 ++++ > >>> 1 file changed, 4 insertions(+) > >>> > >>> diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c > >>> index ac07f55a63e3..0db6473caf13 100644 > >>> --- a/drivers/staging/media/imx/imx7-media-csi.c > >>> +++ b/drivers/staging/media/imx/imx7-media-csi.c > >>> @@ -1017,6 +1017,7 @@ static int imx7_csi_try_fmt(struct imx7_csi *csi, > >>> sdformat->format.width = in_fmt->width; > >>> sdformat->format.height = in_fmt->height; > >>> sdformat->format.code = in_fmt->code; > >>> + sdformat->format.field = in_fmt->field; > >>> *cc = in_cc; > >>> > >>> sdformat->format.colorspace = in_fmt->colorspace; > >>> @@ -1031,6 +1032,9 @@ static int imx7_csi_try_fmt(struct imx7_csi *csi, > >>> false); > >>> sdformat->format.code = (*cc)->codes[0]; > >>> } > >>> + > >>> + if (sdformat->format.field != V4L2_FIELD_INTERLACED) > >>> + sdformat->format.field = V4L2_FIELD_NONE; > >>> break; > >>> default: > >>> return -EINVAL; -- Regards, Laurent Pinchart