Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8E18C10DCE for ; Tue, 10 Mar 2020 04:26:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F8EA2467F for ; Tue, 10 Mar 2020 04:26:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726150AbgCJE0k (ORCPT ); Tue, 10 Mar 2020 00:26:40 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:38115 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725865AbgCJE0k (ORCPT ); Tue, 10 Mar 2020 00:26:40 -0400 Received: by mail-pl1-f195.google.com with SMTP id w3so4922274plz.5 for ; Mon, 09 Mar 2020 21:26:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5D7rWmkJM2mqRoq49pBX7cCOAgivm4ca9OqlJTQKgC0=; b=N5oYhNs9xdRl24maJMf3MtYcEGznI1l82Lm+z7S+s+rrKKbWFF3GoWOffKRLxIMXEs Nw4o/mBk7GcmxnsEHR77fR3jj/ak0coO/nr2Ve6R62I9mXDEzqDA3kGZ3j93sdxzDbIi AN77hYsGX2n6G/BR9vUTXZIq9YeMtD3u3fN+LFzH6XRRvaWJS0E0uaRY3MwIYcbuYmzf b+G2WDUYxtQStZ3yqsJk5DIFLsEgQwjK0V/GTMdIakSQ6fh8M1DvFi9pPRxAGvyrI59Z pbKCJkJlDyjLerSYqXMe1b873+HK7h4D1Y8yejejmL/BHlo84uy59fhFCIcRG1dYmf2X qr8A== X-Gm-Message-State: ANhLgQ3bNb/UBWkfgIifvX7jfrDDnat50OlRptLzTN2LyV7pUNXW9044 anmzxZlbBXoaOw02CQpYJhs= X-Google-Smtp-Source: ADFU+vt9DoIH6O2H39UJgryyU0WuEK2JbYuMtlP6cFZCBXgX8AU0f0F+bvPIHBmDuZY3h+JN02tjPg== X-Received: by 2002:a17:902:b210:: with SMTP id t16mr18228064plr.65.1583814397690; Mon, 09 Mar 2020 21:26:37 -0700 (PDT) Received: from asus.hsd1.ca.comcast.net ([2601:647:4000:d7:c0e4:71da:7a83:2357]) by smtp.gmail.com with ESMTPSA id l189sm5963240pga.64.2020.03.09.21.26.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2020 21:26:35 -0700 (PDT) From: Bart Van Assche To: Jens Axboe Cc: linux-block@vger.kernel.org, Christoph Hellwig , Bart Van Assche , Christoph Hellwig , Ming Lei , Hannes Reinecke , Johannes Thumshirn , Chaitanya Kulkarni Subject: [PATCH v4 4/8] null_blk: Suppress an UBSAN complaint triggered when setting 'memory_backed' Date: Mon, 9 Mar 2020 21:26:19 -0700 Message-Id: <20200310042623.20779-5-bvanassche@acm.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200310042623.20779-1-bvanassche@acm.org> References: <20200310042623.20779-1-bvanassche@acm.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Although it is not clear to me why UBSAN complains when 'memory_backed' is set, this patch suppresses the UBSAN complaint that is triggered when setting that configfs attribute. UBSAN: Undefined behaviour in drivers/block/null_blk_main.c:327:1 load of value 16 is not a valid value for type '_Bool' CPU: 2 PID: 8396 Comm: check Not tainted 5.6.0-rc1-dbg+ #14 Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 Call Trace: dump_stack+0xa5/0xe6 ubsan_epilogue+0x9/0x26 __ubsan_handle_load_invalid_value+0x6d/0x76 nullb_device_memory_backed_store.cold+0x2c/0x38 [null_blk] configfs_write_file+0x1c4/0x250 [configfs] __vfs_write+0x4c/0x90 vfs_write+0x145/0x2c0 ksys_write+0xd7/0x180 __x64_sys_write+0x47/0x50 do_syscall_64+0x6f/0x2f0 entry_SYSCALL_64_after_hwframe+0x49/0xbe Cc: Christoph Hellwig Cc: Ming Lei Cc: Hannes Reinecke Cc: Johannes Thumshirn Reviewed-by: Chaitanya Kulkarni Signed-off-by: Bart Van Assche --- drivers/block/null_blk_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c index 133060431dbd..b8a08b82b882 100644 --- a/drivers/block/null_blk_main.c +++ b/drivers/block/null_blk_main.c @@ -276,7 +276,7 @@ nullb_device_##NAME##_store(struct config_item *item, const char *page, \ { \ int (*apply_fn)(struct nullb_device *dev, TYPE new_value) = APPLY;\ struct nullb_device *dev = to_nullb_device(item); \ - TYPE uninitialized_var(new_value); \ + TYPE new_value = 0; \ int ret; \ \ ret = nullb_device_##TYPE##_attr_store(&new_value, page, count);\