From: Andy Shevchenko Date: Tue, 10 Mar 2020 16:46:19 +0200 Subject: [PATCH v2 12/39] dm: core: Add basic ACPI support In-Reply-To: <20200308214442.v2.12.Ia5e9ba1f146567b18e9183395484bf04d2e5ba6a@changeid> References: <20200309034504.149659-1-sjg@chromium.org> <20200308214442.v2.12.Ia5e9ba1f146567b18e9183395484bf04d2e5ba6a@changeid> Message-ID: <20200310144619.GN1922688@smile.fi.intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, Mar 08, 2020 at 09:44:36PM -0600, Simon Glass wrote: > ACPI (Advanced Configuration and Power Interface) is an Intel standard Not Intel for a long time. Or more precisely, not *only* Intel. Also this should be corrected (I guess dropping Intel would work) everywhere in this series. > for specifying information about a platform. > It is a little like device > tree but considerably more complicated and with more backslashes. For what purpose this passage? Isn't the same reason why ARM64 choose ACPI to be supported for servers? > A > primary difference is that it supports an interpreted bytecode language. > > Driver model does not use ACPI for U-Boot's configuration, but it is > convenient to have it support generation of ACPI tables for passing to > Linux, etc. > > As a starting point, add an optional set of ACPI operations to each > device. Initially only a single operation is available, to obtain the > ACPI name for the device. More operations are added later. > > Enable ACPI for sandbox to ensure build coverage and so that we can add > tests. ... > +/* Length of an ACPI name string, excluding nul terminator */ > +#define ACPI_NAME_LEN 4 > + > +/* Length of an ACPI name string including nul terminator */ > +#define ACPI_NAME_MAX 5 Do we really need two definitions? ... > + /* Intel Advanced Configuration and Power Interface (ACPI) */ Same as above for commit message. -- With Best Regards, Andy Shevchenko