From: Mark Brown Date: Thu, 12 Mar 2020 12:18:16 +0000 Subject: Re: [PATCH] spi: spi-nxp-fspi: Fix a NULL vs IS_ERR() check in probe Message-Id: <20200312121816.GC4038@sirena.org.uk> MIME-Version: 1 Content-Type: multipart/mixed; boundary="QRj9sO5tAVLaXnSD" List-Id: References: <20200312113154.GC20562@mwanda> In-Reply-To: To: Fabio Estevam Cc: Dan Carpenter , Yogesh Gaur , Han Xu , Adam Ford , Ashish Kumar , linux-spi , kernel-janitors@vger.kernel.org --QRj9sO5tAVLaXnSD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 12, 2020 at 09:11:44AM -0300, Fabio Estevam wrote: > On Thu, Mar 12, 2020 at 8:33 AM Dan Carpenter wrote: > > The commit message for commit d166a73503ef ("spi: fspi: dynamically > > alloc AHB memory") is not very good. Why is it necessary to allocate > > the AHB memory dynamically instead of during probe? Also I suspect that > Agreed and I made the same comment during review: > https://patchwork.kernel.org/patch/11361581/ Indeed. There had been an earlier discussion of what it was doing IIRC but it didn't make it's way into the changelog. --QRj9sO5tAVLaXnSD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5qKIcACgkQJNaLcl1U h9BqVAgAhEVYC3gX7h7lG4zaL2N7m2EahKxIbHvpVFZF1cfdBiKQgF8Mj7ARC9Ll rHHP0vQkgrHYVy5tmZJtF278eNq/QWAfgNOD17NDPiyd0HfL+tdnTmefLkSvzroE E2cVcXprfYn6sasUvW2EF5iufc3XSKBSV4UrSKFjGSiie+lNxIzFj765PQXvS9gt Va99+r5e5nTRRp3YUO/8cKTALx69BhK3qBFTAqG3HC9dWOxaftL3lxo8ppiKrrIO +D2/CSOPqU+3kLlqrMWXxVs/oJVWg2QneYZP8DU4AOLQ6HjFXnYlkETS4V6uXBKH 0RcRBTtnwURqpgHOrIFN1ZcdlEmbAg== =oAWz -----END PGP SIGNATURE----- --QRj9sO5tAVLaXnSD--