Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64A5BC10DCE for ; Fri, 13 Mar 2020 11:06:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43FA0206E2 for ; Fri, 13 Mar 2020 11:06:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726455AbgCMLGQ (ORCPT ); Fri, 13 Mar 2020 07:06:16 -0400 Received: from verein.lst.de ([213.95.11.211]:41953 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726426AbgCMLGP (ORCPT ); Fri, 13 Mar 2020 07:06:15 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id E2AB768C4E; Fri, 13 Mar 2020 12:06:12 +0100 (CET) Date: Fri, 13 Mar 2020 12:06:12 +0100 From: Christoph Hellwig To: Bart Van Assche Cc: "Martin K . Petersen" , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, Christoph Hellwig , Andy Shevchenko , Greg Kroah-Hartman , Keith Busch , Sagi Grimberg , Jens Axboe , Felipe Balbi , Harvey Harrison , Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" , Andrew Morton Subject: Re: [PATCH v2 3/5] treewide: Consolidate {get,put}_unaligned_[bl]e24() definitions Message-ID: <20200313110612.GB8132@lst.de> References: <20200313023718.21830-1-bvanassche@acm.org> <20200313023718.21830-4-bvanassche@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200313023718.21830-4-bvanassche@acm.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Thu, Mar 12, 2020 at 07:37:16PM -0700, Bart Van Assche wrote: > Move the get_unaligned_be24(), get_unaligned_le24() and > put_unaligned_le24() definitions from various drivers into > include/linux/unaligned/generic.h. Add a put_unaligned_be24() > implementation. Looks good: Reviewed-by: Christoph Hellwig (although the added consts suggested by Andy look useful to me)