From: Tony Lindgren Subject: Re: [PATCH v2 4/6] pwm: omap-dmtimer: Fix pwm disabling sequence Date: Fri, 13 Mar 2020 08:34:49 -0700 Message-ID: <20200313153449.GD37466@atomide.com> References: <20200228095651.32464-1-lokeshvutla@ti.com> <20200228095651.32464-5-lokeshvutla@ti.com> <20200306181443.GJ37466@atomide.com> <9129d4fe-a17e-2fa6-764c-6a746fa5096d@ti.com> <20200309180123.GP37466@atomide.com> <666dbb7a-db98-d16a-ee73-27d353d2a317@ti.com> <20200310155242.GT37466@atomide.com> <296e28b7-7925-5dfa-ce5a-c0b2a2f1c2e0@ti.com> <20200312005849.GY37466@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from muru.com ([72.249.23.125]:60066 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726664AbgCMPex (ORCPT ); Fri, 13 Mar 2020 11:34:53 -0400 Content-Disposition: inline In-Reply-To: <20200312005849.GY37466@atomide.com> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Lokesh Vutla Cc: Thierry Reding , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Linux OMAP Mailing List , linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Sekhar Nori , Vignesh R , Sebastian Reichel * Tony Lindgren [200312 00:59]: > * Lokesh Vutla [200311 04:14]: > > However, I see an issue with the patch itself as pm_runtime is not disabled > > after the pwm is stopped. Not sure how that could be nullified with this approach. > > Hmm yeah not sure what could be used to clear things > when the current cycle is completed unless there's > some interrupt for it. You could enable pm_runtime_use_autosuspend() for pwm use, then set the timeout to the cycle length, then in the runtime_suspend make sure the enable bit is cleared if requested. But this too seems inaccurate, it would be best to clear the enable bit on some cycle completion interrupt if such thing is available. Regards, Tony