From: mwilck@suse.com Subject: [PATCH v2 1/4] libmpathpersist: limit PRIN allocation length to 8192 bytes Date: Sun, 15 Mar 2020 22:05:18 +0100 Message-ID: <20200315210521.12109-2-mwilck@suse.com> References: <20200315210521.12109-1-mwilck@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200315210521.12109-1-mwilck@suse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Christophe Varoqui , Benjamin Marzinski Cc: dm-devel@redhat.com, Martin Wilck List-Id: dm-devel.ids From: Martin Wilck Some targets (notably the qemu-pr-helper) don't support PERSISTENT RESERVE IN commands with more than 8192 bytes allocation length. While I have found no explicit requirement in the SCSI specs that the allocation lengh may not exceed 8k, an 8k limit is also enforced by sg_persist(8), and actually by mpathpersist itself for the --allocation-length option, but not for the auto-determined length. Fix that. Reviewed-by: Benjamin Marzinski Signed-off-by: Martin Wilck --- libmpathpersist/mpath_pr_ioctl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libmpathpersist/mpath_pr_ioctl.c b/libmpathpersist/mpath_pr_ioctl.c index 74b26b0c..1a28cba7 100644 --- a/libmpathpersist/mpath_pr_ioctl.c +++ b/libmpathpersist/mpath_pr_ioctl.c @@ -543,5 +543,7 @@ int get_prin_length(int rq_servact) mx_resp_len = 0; break; } + if (mx_resp_len > MPATH_MAX_PARAM_LEN) + mx_resp_len = MPATH_MAX_PARAM_LEN; return mx_resp_len; } -- 2.25.1