Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34FE0C0044D for ; Mon, 16 Mar 2020 09:52:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 17EB120658 for ; Mon, 16 Mar 2020 09:52:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730445AbgCPJwt (ORCPT ); Mon, 16 Mar 2020 05:52:49 -0400 Received: from verein.lst.de ([213.95.11.211]:53434 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730423AbgCPJwt (ORCPT ); Mon, 16 Mar 2020 05:52:49 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 37BE368CEC; Mon, 16 Mar 2020 10:52:46 +0100 (CET) Date: Mon, 16 Mar 2020 10:52:46 +0100 From: Christoph Hellwig To: Bart Van Assche Cc: "Martin K . Petersen" , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, Christoph Hellwig , Andy Shevchenko , Greg Kroah-Hartman , Mark Salter , Aurelien Jacquiot Subject: Re: [PATCH v3 2/5] c6x: Include instead of duplicating it Message-ID: <20200316095246.GA13730@lst.de> References: <20200313203102.16613-1-bvanassche@acm.org> <20200313203102.16613-3-bvanassche@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200313203102.16613-3-bvanassche@acm.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Fri, Mar 13, 2020 at 01:30:59PM -0700, Bart Van Assche wrote: > Use the generic __{get,put}_unaligned_[bl]e() definitions instead of > duplicating these. Since a later patch will add more definitions into > , this patch ensures that these definitions > have to be added only once. See also commit a7f626c1948a ("C6X: headers"). > See also commit 6510d41954dc ("kernel: Move arches to use common unaligned > access"). Looks good, Reviewed-by: Christoph Hellwig