From: Andy Shevchenko Subject: Re: [PATCH v2 1/3] i2c: core: Provide generic definitions for bus frequencies Date: Mon, 16 Mar 2020 17:51:17 +0200 Message-ID: <20200316155117.GR1922688@smile.fi.intel.com> References: <20200227122129.65516-1-andriy.shevchenko@linux.intel.com> <73b9a005-e4b1-5dbf-5769-ee0866ba8c4e@axentia.se> <20200306101049.GT1224808@smile.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from mga09.intel.com ([134.134.136.24]:50340 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732107AbgCPPvQ (ORCPT ); Mon, 16 Mar 2020 11:51:16 -0400 Content-Disposition: inline In-Reply-To: <20200306101049.GT1224808@smile.fi.intel.com> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Peter Rosin Cc: Wolfram Sang , "linux-i2c@vger.kernel.org" , Mika Westerberg On Fri, Mar 06, 2020 at 12:10:49PM +0200, Andy Shevchenko wrote: > On Thu, Mar 05, 2020 at 09:58:29PM +0000, Peter Rosin wrote: > > On 2020-02-27 13:21, Andy Shevchenko wrote: ... > > > +/* I2C Frequency Modes */ > > > +#define I2C_MAX_STANDARD_MODE_FREQ 100000 > > > +#define I2C_MAX_FAST_MODE_FREQ 400000 > > > +#define I2C_MAX_FAST_PLUS_MODE_FREQ 1000000 > > > +#define I2C_MAX_TURBO_MODE_FREQ 1400000 > > > +#define I2C_MAX_HIGH_SPEED_MODE_FREQ 3400000 > > > +#define I2C_MAX_ULTRA_SPEED_MODE_FREQ 5000000 > > I can't seem to > > remember what frequency TURBO, HIGH, etc are and their ordering is > > difficult. It's all sounds like marketing buzz to me and my brain shuts > > off instantly. > > > > This feels a lot like moving away from octal permissions for files, which > > is frowned upon... > > > > Can we include some kind of indication of the actual frequency in the > > names as well please? > > > > Perhaps something like I2C_MAX_STANDARD_MODE_100KHZ? > > It's definitely a duplicate information here. > > In I²C we have quite established range of frequencies (4 out of 6 in above > list), so, their names already implying very well defined frequencies. Actually 5 out of 6. In new version (just sent) I put a link to Wiki. -- With Best Regards, Andy Shevchenko