From: Daniel Vetter Subject: Re: [PATCH v3] drm/bochs: downgrade pci_request_region failure from error to warning Date: Tue, 17 Mar 2020 17:49:41 +0100 Message-ID: <20200317164941.GP2363188@phenom.ffwll.local> References: <20200313084152.2734-1-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20200313084152.2734-1-kraxel@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, marmarek@invisiblethingslab.com, David Airlie , Daniel Vetter , "open list:DRM DRIVER FOR BOCHS VIRTUAL GPU" , open list List-Id: virtualization@lists.linuxfoundation.org On Fri, Mar 13, 2020 at 09:41:52AM +0100, Gerd Hoffmann wrote: > Shutdown of firmware framebuffer has a bunch of problems. Because > of this the framebuffer region might still be reserved even after > drm_fb_helper_remove_conflicting_pci_framebuffers() returned. Is that still the fbdev lifetime fun where the cleanup might be delayed if the char device node is still open? -Daniel > > Don't consider pci_request_region() failure for the framebuffer > region as fatal error to workaround this issue. > > Reported-by: Marek Marczykowski-Górecki > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/bochs/bochs_hw.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bochs/bochs_hw.c b/drivers/gpu/drm/bochs/bochs_hw.c > index 952199cc0462..dce4672e3fc8 100644 > --- a/drivers/gpu/drm/bochs/bochs_hw.c > +++ b/drivers/gpu/drm/bochs/bochs_hw.c > @@ -157,10 +157,8 @@ int bochs_hw_init(struct drm_device *dev) > size = min(size, mem); > } > > - if (pci_request_region(pdev, 0, "bochs-drm") != 0) { > - DRM_ERROR("Cannot request framebuffer\n"); > - return -EBUSY; > - } > + if (pci_request_region(pdev, 0, "bochs-drm") != 0) > + DRM_WARN("Cannot request framebuffer, boot fb still active?\n"); > > bochs->fb_map = ioremap(addr, size); > if (bochs->fb_map == NULL) { > -- > 2.18.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch