Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jEHO8-0006YS-UP for mharc-grub-devel@gnu.org; Tue, 17 Mar 2020 14:56:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57669) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEHO4-0006YI-NH for grub-devel@gnu.org; Tue, 17 Mar 2020 14:56:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEHO3-0005jd-Hw for grub-devel@gnu.org; Tue, 17 Mar 2020 14:56:24 -0400 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::12]:28990) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jEHO2-0005LT-Sb for grub-devel@gnu.org; Tue, 17 Mar 2020 14:56:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1584471378; s=strato-dkim-0002; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:X-RZG-CLASS-ID:X-RZG-AUTH:From: Subject:Sender; bh=FF5Qfs/VlMask5sVOL9qQeng6KwvXev+f9YXJGYwFVw=; b=bI/b0bw6y3Ct/ENoR4Zf1mdi9N29KA8sk62/DNl7aTM6CPepS5EK92mWeSsapDvc4j ElaSZz6yQDz3FsveA1yJGuxU4tiA7lopW46rNA/DEgzu/C+cpLl3pZp433aQdDOq6mPe qo3w5omB9Stg0a4tz+24O4f6CGRedhPpXjXWK353//ergD81Wh2+Ot0lUsu6iH9xqxy5 zIF0k1o3k9zrpVQopPn/UxOWWsR+yLZ/Js97XNj79nAA43B2etgrwBfK/zJckxh1Grwx 2d5iYNaFbp/Z2+w31FyB+TBER+F4geBLSlDHq1s9g70p2ZkXwJKSNb1gJkYaFGf0J7d6 zveQ== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzBW/OdlBZQ4AHSS329Ojw==" X-RZG-CLASS-ID: mo00 Received: from sender by smtp.strato.de (RZmta 46.2.0 DYNA|AUTH) with ESMTPSA id u021a0w2HIuIE3W (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256 bits)) (Client did not present a certificate); Tue, 17 Mar 2020 19:56:18 +0100 (CET) From: Olaf Hering To: grub-devel@gnu.org Cc: Olaf Hering Subject: [PATCH v1] http: return error on unhandled HTTP error responses Date: Tue, 17 Mar 2020 19:56:14 +0100 Message-Id: <20200317185614.7506-1-olaf@aepfle.de> X-Mailer: git-send-email 2.16.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a01:238:20a:202:5300::12 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2020 18:56:27 -0000 A http transfer will hang if an unhandled error is returned. The error branch returns the value zero, which is not expected by the caller. Signed-off-by: Olaf Hering --- grub-core/net/http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/net/http.c b/grub-core/net/http.c index b616cf40b..9d92a4905 100644 --- a/grub-core/net/http.c +++ b/grub-core/net/http.c @@ -125,7 +125,7 @@ parse_line (grub_file_t file, http_data_t data, char *ptr, grub_size_t len) valid answers like 403 will trigger this very generic message. */ data->errmsg = grub_xasprintf (_("unsupported HTTP error %d: %s"), code, ptr); - return GRUB_ERR_NONE; + return GRUB_ERR_FILE_READ_ERROR; } data->first_line_recv = 1; return GRUB_ERR_NONE;