From: Wolfgang Denk Date: Tue, 17 Mar 2020 21:15:40 +0100 Subject: [PATCH] powerpc: remove WATCHDOG_RESET call from wait_ticks() In-Reply-To: <86e1c45a-fc23-6794-7ca9-e96910af4743@prevas.dk> References: <20200316212337.30204-1-rasmus.villemoes@prevas.dk> <20200317100249.1DECD24003E@gemini.denx.de> <1b6c7efd-8264-6cb5-0b39-3223bae5f8dc@prevas.dk> <20200317122144.C479B24003E@gemini.denx.de> <01193803-be8f-865d-5fce-2c7cee0fd9af@prevas.dk> <20200317143128.AB9B424003E@gemini.denx.de> <86e1c45a-fc23-6794-7ca9-e96910af4743@prevas.dk> Message-ID: <20200317201540.3392524003E@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Rasmus, In message <86e1c45a-fc23-6794-7ca9-e96910af4743@prevas.dk> you wrote: > > > Testing on a single platform (which apparently has aother problems, > > or you would not need any such change) is not convincing. > > I don't, actually, need this change, but suggested it as a way towards > making the primitives available a little more consistent across > architectures since I stumbled on this implementation detail while > single-stepping my board to figure out why it would reset in the SPL. As > I'm unable to convince you that the benefits of that outweigh the risk > of introducing a regression, feel free to drop it. OK. > I do, however, need the other ppc patch I sent yesterday: > https://patchwork.ozlabs.org/patch/1255844/ . That one should satisfy > the requirement that it cannot possibly break anything for existing boards. This other patch lacks documentation - just from reading the code nobody will be able to understand what this piece of code is intended for, so there is a risk that it might be removed by some later "cleanup". Please add some comment in the code to explain the intentions. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Defaults are wonderful, just like fire. - Larry Wall in <1996Mar6.004121.27890@netlabs.com>