From: Tom Rini Date: Wed, 18 Mar 2020 08:54:57 -0400 Subject: [PATCH 3/3] cmd: dm: Fixed/Added DM driver listing subcommands In-Reply-To: <7d7f4c4d-2371-a4cd-bf1b-d9cdd9f7d51b@denx.de> References: <20200317140906.858558-1-lusus@denx.de> <20200317140906.858558-4-lusus@denx.de> <7d7f4c4d-2371-a4cd-bf1b-d9cdd9f7d51b@denx.de> Message-ID: <20200318125457.GA12423@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Mar 18, 2020 at 01:22:03PM +0100, Niel Fourie wrote: > Hi Tom, > > On 3/17/20 7:51 PM, Sean Anderson wrote: > > On 3/17/20 10:09 AM, Niel Fourie wrote: > > > Renamed dm "drivers" subcommand to "compat" (as it listed > > > compatibility strings) and prevent it from segfaulting when > > > drivers have no of_match populated. > > > > > > Added a new "drivers" subcommand to dump a list of all known DM > > > drivers and for each, their uclass id, uclass driver and names of > > > attached devices. > > > > > > Added a new "static" subcommand to dump a list of DM drivers with > > > statically defined platform data. > > > > > > Signed-off-by: Niel Fourie > > > CC: Simon Glass > > > --- > > > cmd/dm.c | 24 ++++++++++++++++-- > > > drivers/core/dump.c | 60 ++++++++++++++++++++++++++++++++++++++++++++- > > > include/dm/util.h | 6 +++++ > > > 3 files changed, 87 insertions(+), 3 deletions(-) > > > > > In drivers/core/dump.c: > > > -void dm_dump_drivers(void) > > > +void dm_dump_driver_compat(void) > > > { > > > struct driver *d = ll_entry_start(struct driver, driver); > > > const int n_ents = ll_entry_count(struct driver, driver); > > > @@ -107,6 +107,9 @@ void dm_dump_drivers(void) > > > puts("Driver Compatible\n"); > > > puts("--------------------------------\n"); > > > for (entry = d; entry < d + n_ents; entry++) { > > > + if (!entry->of_match) { > > > + continue; > > > + } > > > > This should have been fixed in version 2 of the patch [1]. > > > > [1] https://patchwork.ozlabs.org/patch/1234460/ > > > > Should I rebase my series on the version 2 of the above patch, or should I > simply include that change in my series instead? Thanks in advance! Please rebase on top of, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: