Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B817C10F29 for ; Wed, 18 Mar 2020 17:51:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D8E9C20757 for ; Wed, 18 Mar 2020 17:51:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726623AbgCRRve (ORCPT ); Wed, 18 Mar 2020 13:51:34 -0400 Received: from mx2.suse.de ([195.135.220.15]:50562 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726596AbgCRRve (ORCPT ); Wed, 18 Mar 2020 13:51:34 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 77A3BABE7; Wed, 18 Mar 2020 17:51:32 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 48AB21E11A0; Wed, 18 Mar 2020 18:51:31 +0100 (CET) Date: Wed, 18 Mar 2020 18:51:31 +0100 From: Jan Kara To: Amir Goldstein Cc: Jan Kara , linux-fsdevel Subject: Re: [PATCH v2 11/16] fanotify: prepare to encode both parent and child fid's Message-ID: <20200318175131.GK22684@quack2.suse.cz> References: <20200227112755.GZ10728@quack2.suse.cz> <20200227133016.GD10728@quack2.suse.cz> <20200305154908.GK21048@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sun 08-03-20 09:29:08, Amir Goldstein wrote: > > To see what the benefit of inherit fanotify_fid_event is, I did a test patch > > to get rid of it and pushed the result to fanotify_name-wip: > > > > * b7eb8314c61b - fanotify: do not inherit fanotify_name_event from > > fanotify_fid_event > > > > IMO, the removal of inheritance in this struct is artificial and > > brings no benefit. > > There is not a single line of code that improved IMO vs. several added > > helpers which abstract something that is pretty obvious. > > > > That said, I don't mind going with this variant. > > Let me you what your final call is. > > > > Eventually, it was easier to work the non-inherited variant into the series > as the helpers aid with abstracting things as the series progresses and > because object_fh is added to fanotify_name_event late in the series. > So I went with your preference. > > Pushed the work to fanotify_name branch. > Let me know if you want me to post v3. So I went through the patches - had only minor comments for most of them. Can you post the next revision by email and I'll pickup at least the obvious preparatory patches to my tree. Thanks! Honza -- Jan Kara SUSE Labs, CR