Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jFcb5-00029I-Ee for mharc-qemu-trivial@gnu.org; Sat, 21 Mar 2020 07:47:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35032) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcb2-00022J-2I for qemu-trivial@nongnu.org; Sat, 21 Mar 2020 07:47:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFcb1-0006rc-0w for qemu-trivial@nongnu.org; Sat, 21 Mar 2020 07:47:19 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:39020) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jFcb0-0006rC-Ts for qemu-trivial@nongnu.org; Sat, 21 Mar 2020 07:47:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584791238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yg/uPhRkx9OjPcaTO9vlYALUXN3pIoYxovXY5zX2+JQ=; b=ANdBkhE71Ysnxc3IpXx1C31x3TUFRrWyb5W/vYjjlLg/lnLmm154AzmAU2OSfDBsVLIcw1 AcRYKl9fXXczbM+VhuUorGKSZDjOASbmptmkxdXAAFHmWgDyVq3GNeOMCxVLNuYW1cHAMs K41Xy1Afg49MQv+FbcPpDnyKjN0GQnw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-357-XCdjykDmOf6fzDl9LBskAw-1; Sat, 21 Mar 2020 07:47:16 -0400 X-MC-Unique: XCdjykDmOf6fzDl9LBskAw-1 Received: by mail-wr1-f69.google.com with SMTP id b12so4216306wro.4 for ; Sat, 21 Mar 2020 04:47:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8CJ+9lz/G6rwsxDBjnubfjrbrfbpIvcJrGa1k2G4+/Y=; b=XIRnZxV7R/sHa9nVWLIGY2mMYscNd1L9JQu56CqLDOjId6q9DmYuvqfmo2i/iQeBcq ARfa8dPwdNblMBsa3pNSddt2KSwNTF73tRGtIpp5qmM6tbcRoJeCdp7u1HO+pCvjiKIZ 6N2UkeBWoQ57hMWbYHc9UURYqcuEcc31lNvKVKnn39fBLWbURFdUB9fkMRCxRGDjeq6Q ZbWtEp77GJyb1ymz8pXB0PWXQrtwhHvd0gGGfxjogTYn+jSGyQ2/gTURIYzR88wu/7PO 3P/8i67qj5Q/ddLrH4K2ZuCqrlP5SvzUoCo8PFNt7ymOrZWDvbolEeAajRNDJnO/gwBG lZzQ== X-Gm-Message-State: ANhLgQ1xGE8jioQwg59FjCsgKYo4N4Fg2oOOgcMDPO6tF6Nx6OzQHxHo ee4YjdkCm19x+bSEN2rT5o70xZ1E3ymBGFMFF1e109EUYhcC4zPPiH7v88phOPMeOL3djwPapVR ZcTXQzIsltaBdwHCwxA== X-Received: by 2002:a05:600c:10ce:: with SMTP id l14mr576557wmd.161.1584791235492; Sat, 21 Mar 2020 04:47:15 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv3kYG0GXzyCiOia7dq8AGBTEPkdgA9K0YR3lk8tgmzZM3dgpvC+FSCqi8gMIeK6PeKsjCiPg== X-Received: by 2002:a05:600c:10ce:: with SMTP id l14mr576530wmd.161.1584791235271; Sat, 21 Mar 2020 04:47:15 -0700 (PDT) Received: from localhost.localdomain (37.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.37]) by smtp.gmail.com with ESMTPSA id y187sm2407206wmd.0.2020.03.21.04.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2020 04:47:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, "Michael S. Tsirkin" , Markus Armbruster , Alistair Francis , BALATON Zoltan , Andrew Jeffery , Andrzej Zaborowski , Laurent Vivier , Peter Maydell , Igor Mitsyanko , David Gibson , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Fam Zheng , qemu-trivial@nongnu.org, Max Reitz , John Snow , Paolo Bonzini , Michael Tokarev , qemu-ppc@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Kevin Wolf , Joel Stanley , Mark Cave-Ayland , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-5.0 07/11] hw/gpio/aspeed_gpio: Remove dead assignment Date: Sat, 21 Mar 2020 12:46:11 +0100 Message-Id: <20200321114615.5360-8-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200321114615.5360-1-philmd@redhat.com> References: <20200321114615.5360-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 216.205.24.74 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Mar 2020 11:47:21 -0000 Fix warning reported by Clang static code analyzer: hw/gpio/aspeed_gpio.c:717:18: warning: Value stored to 'g_idx' during its= initialization is never read int set_idx, g_idx =3D *group_idx; ^~~~~ ~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/gpio/aspeed_gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c index 41e11ea9b0..cc07ab9866 100644 --- a/hw/gpio/aspeed_gpio.c +++ b/hw/gpio/aspeed_gpio.c @@ -714,11 +714,11 @@ static void aspeed_gpio_write(void *opaque, hwaddr of= fset, uint64_t data, static int get_set_idx(AspeedGPIOState *s, const char *group, int *group_i= dx) { AspeedGPIOClass *agc =3D ASPEED_GPIO_GET_CLASS(s); - int set_idx, g_idx =3D *group_idx; + int set_idx; =20 for (set_idx =3D 0; set_idx < agc->nr_gpio_sets; set_idx++) { const GPIOSetProperties *set_props =3D &agc->props[set_idx]; - for (g_idx =3D 0; g_idx < ASPEED_GROUPS_PER_SET; g_idx++) { + for (int g_idx =3D 0; g_idx < ASPEED_GROUPS_PER_SET; g_idx++) { if (!strncmp(group, set_props->group_label[g_idx], strlen(grou= p))) { *group_idx =3D g_idx; return set_idx; --=20 2.21.1