Content-Type: multipart/mixed; boundary="===============4905475536981526714==" MIME-Version: 1.0 From: kbuild test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH] media: dvb: digitv: remove unused array element 0 Date: Mon, 23 Mar 2020 09:04:41 +0800 Message-ID: <202003230831.Osg9AmmM%lkp@intel.com> In-Reply-To: <20200312092245.4471-1-sean@mess.org> List-Id: --===============4905475536981526714== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Sean, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v5.6-rc6 next-20200320] [if your patch is applied to the wrong git tree, please drop us a note to h= elp improve the system. BTW, we also suggest to use '--base' option to specify = the base tree in git format-patch, please see https://stackoverflow.com/a/37406= 982] url: https://github.com/0day-ci/linux/commits/Sean-Young/media-dvb-digit= v-remove-unused-array-element-0/20200313-024740 base: git://linuxtv.org/media_tree.git master If you fix the issue, kindly add following tag Reported-by: kbuild test robot smatch warnings: drivers/media/usb/dvb-usb/digitv.c:262 digitv_rc_query() warn: inconsistent= indenting vim +262 drivers/media/usb/dvb-usb/digitv.c 230 = 231 static int digitv_rc_query(struct dvb_usb_device *d, u32 *event, int= *state) 232 { 233 int ret, i; 234 u8 key[4]; 235 u8 b[4] =3D { 0 }; 236 = 237 *event =3D 0; 238 *state =3D REMOTE_NO_KEY_PRESSED; 239 = 240 ret =3D digitv_ctrl_msg(d, USB_READ_REMOTE, 0, NULL, 0, key, 4); 241 if (ret) 242 return ret; 243 = 244 /* Tell the device we've read the remote. Not sure how necessary 245 this is, but the Nebula SDK does it. */ 246 ret =3D digitv_ctrl_msg(d, USB_WRITE_REMOTE, 0, b, 4, NULL, 0); 247 if (ret) 248 return ret; 249 = 250 /* if something is inside the buffer, simulate key press */ 251 if (key[0] !=3D 0) 252 { 253 for (i =3D 0; i < d->props.rc.legacy.rc_map_size; i++) { 254 if (rc5_custom(&d->props.rc.legacy.rc_map_table[i]) =3D=3D key[0]= && 255 rc5_data(&d->props.rc.legacy.rc_map_table[i]) =3D=3D key[1]) { 256 *event =3D d->props.rc.legacy.rc_map_table[i].keycode; 257 *state =3D REMOTE_KEY_PRESSED; 258 return 0; 259 } 260 } 261 = > 262 deb_rc("key: %*ph\n", 4, key); 263 } 264 = 265 return 0; 266 } 267 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============4905475536981526714==--