Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10B8AC43331 for ; Tue, 24 Mar 2020 18:58:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D63BC20789 for ; Tue, 24 Mar 2020 18:58:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P1HOQcI5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D63BC20789 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QNMuTH9YoF/UGBNItxOpLEwUX4jQnhIjbOsDWBa395I=; b=P1HOQcI5ZxHvw7HHDMtPvUEA3 tRU51WYzdCQjrZgwe+VKXFWoWp4Tr5UBRi0s7riwyq8OnOWzunjmEcchpm+1JQtXeNBtALqwl5iun cLcBflaFn/NQOAp4bDV38T7q+uHQMGrTfnb9WWx8lIt8Kl88uzypxvye6+F1FL70NI9sp4HFLtvTk h9L+UZblYOvRhdps6/zF9vzLtdCbpkFwJenNwKTdbDR2mN6JhtM9dvMxParM1V6pmnOhB4iTd6FNc av5zSTdPTZBNFcb7Tg0aUf/zIT5KYG3WnPh3cjv/2ZOHQj310rZHT9gFXWZLKxoonESrA350r+wKk bFVlrs1iw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGolJ-0004c4-2V; Tue, 24 Mar 2020 18:58:53 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGolG-0004bE-BV for linux-arm-kernel@lists.infradead.org; Tue, 24 Mar 2020 18:58:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 649C331B; Tue, 24 Mar 2020 11:58:49 -0700 (PDT) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DB5023F71F; Tue, 24 Mar 2020 11:58:48 -0700 (PDT) Date: Tue, 24 Mar 2020 18:58:47 +0000 From: Mark Brown To: Ard Biesheuvel Subject: Re: [PATCH 1/2] arm64: lib: Use .arch_extension Message-ID: <20200324185847.GJ7039@sirena.org.uk> References: <20200323191807.3864-1-broonie@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Cookie: I feel ... JUGULAR ... User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200324_115850_439326_EBDF4AC6 X-CRM114-Status: GOOD ( 15.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon , linux-arm-kernel , Eric Biggers Content-Type: multipart/mixed; boundary="===============7214042870613902324==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7214042870613902324== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5me2qT3T17SWzdxI" Content-Disposition: inline --5me2qT3T17SWzdxI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 24, 2020 at 07:19:17PM +0100, Ard Biesheuvel wrote: > On Mon, 23 Mar 2020 at 20:18, Mark Brown wrote: > > order to generate BTI landing pads. We did this due to a lack of > > support for the .arch_extension gas feature in older versions of the > > clang built in assembler but since current versions of clang now have > > support for .arch_extension we can use that. > This is not 100% accurate. Support for .arch_extension was added to > GAS/aarch64 much later, so we should at least double check that it > works on the oldest binutils that we do support. Ah, OK - the information I figured out from history was misleading sorry. =20 We've already got quite a lot of usages of .arch_extension in the kernel for arm and a couple for arm64 (one in TF and another for LSE). It looks like the feature was added in binutils 2.26 which is newer than the current advertised minimum binutils version of 2.21 but dates from 2016 (the code was added in 2014 and looks like it might've appeared in downstream releases earlier) so is pretty old in arm64 terms. If that's not OK I've got an open coded version for BTI that does this with macros but it's obviously not as nice. I do wish the binutils docs included information on when features were added, it'd make life easier :/ --5me2qT3T17SWzdxI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl56WGYACgkQJNaLcl1U h9CMIAf/eD4IfOb7vDMsyY/fzFZ+EsgS4Bz0DpXI1bm5283/AMD0kZdXfbWCRsSL nCHWLA418iO+7dr8xJ3W+NYEc0HZOI/MkdByZFStqJPXjJCXJ1FmRyfeGvP83715 xwj9cr+ciY7gK1SraQJyTAwq6Bq4FFYH1BZzpIkOT2czv9fgwC2dVt8G31bJLGjb b1v1Zbn6Bh3E/COgiD34JLkwH+aawRpkzbJdzYJfMbETKsB4x/AVCCjcOt8ZVrZ2 DO0sdRDrYqohgG5l/T+DDvul6zFSvxnJPbraDWzNlGd355iiGqiTpShkuwUI7NGu 6rbwZfvqN6VBFEeTwW2zsYl7GPv9EA== =XrKB -----END PGP SIGNATURE----- --5me2qT3T17SWzdxI-- --===============7214042870613902324== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7214042870613902324==--