Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 090DFC43331 for ; Sun, 29 Mar 2020 13:48:57 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD3B42073B for ; Sun, 29 Mar 2020 13:48:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="Yv/1Ysp/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD3B42073B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jIYIw-000455-87; Sun, 29 Mar 2020 13:48:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jIYIu-00044s-W0 for xen-devel@lists.xenproject.org; Sun, 29 Mar 2020 13:48:45 +0000 X-Inumbo-ID: 01374f74-71c4-11ea-8d94-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 01374f74-71c4-11ea-8d94-12813bfff9fa; Sun, 29 Mar 2020 13:48:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID :Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=dMeLDkByMNmT1EIlc/J38W18kXT0ER8zOpubOOgkMYE=; b=Yv/1Ysp/6/9awpHfZ/3NZWQLHf uVWWnht+ugQwBEmAQNsnrbUglObK4fkmn1erXszrn7cRT4p+CHJUhwvo86wWN/2GChQvYSELwGy5I GgZ47f0QkcqDAor//JfhyTWDhpmAZ91L8cPpAxviobmpAIT9DTJGOklHIYN/KlpXM6Ks=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jIYIs-0003na-W1; Sun, 29 Mar 2020 13:48:42 +0000 Received: from 44.142.6.51.dyn.plus.net ([51.6.142.44] helo=debian) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jIYIs-0001nL-NP; Sun, 29 Mar 2020 13:48:42 +0000 Date: Sun, 29 Mar 2020 14:48:39 +0100 From: Wei Liu To: Simran Singhal Message-ID: <20200329134839.akygrmhq3qxxsrtl@debian> References: <20200329061608.GA29651@simran-Inspiron-5558> <20200329134657.zdbanqkhzmtmurue@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200329134657.zdbanqkhzmtmurue@debian> User-Agent: NeoMutt/20180716 Subject: Re: [Xen-devel] [PATCH] xen/x86: Compress lines for immediate return X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu , Jan Beulich , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Sun, Mar 29, 2020 at 02:46:57PM +0100, Wei Liu wrote: > On Sun, Mar 29, 2020 at 11:46:08AM +0530, Simran Singhal wrote: > > diff --git a/xen/arch/x86/oprofile/op_model_athlon.c b/xen/arch/x86/oprofile/op_model_athlon.c > > index 5c48f868ae..2bc0d04a1f 100644 > > --- a/xen/arch/x86/oprofile/op_model_athlon.c > > +++ b/xen/arch/x86/oprofile/op_model_athlon.c > > @@ -343,9 +343,8 @@ static int athlon_check_ctrs(unsigned int const cpu, > > } > > } > > > > - ovf = handle_ibs(mode, regs); > > /* See op_model_ppro.c */ > > - return ovf; > > + return handle_ibs(mode, regs); > > Hmm... ovf can potentially be set in the for loop before this hunk, but > then immediately get overwritten by the function call. I bet the ovf = 1 > line is the reason why you didn't remove ovf out right. > > I think you can perhaps just remove ovf here. It would make any > difference logically. I meant "It would _not_ make any difference logically" here. Wei.