Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFC2BC43331 for ; Sun, 29 Mar 2020 14:52:55 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8772920733 for ; Sun, 29 Mar 2020 14:52:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="D+yBrfIj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8772920733 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jIZIT-0001On-Ta; Sun, 29 Mar 2020 14:52:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jIZIT-0001Oi-4G for xen-devel@lists.xenproject.org; Sun, 29 Mar 2020 14:52:21 +0000 X-Inumbo-ID: e46f980c-71cc-11ea-92cf-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e46f980c-71cc-11ea-92cf-bc764e2007e4; Sun, 29 Mar 2020 14:52:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jiuxIoNp2NwvvwYuGrrUOXoLd19b2PzyNnIiQnFwKVI=; b=D+yBrfIjFWUO0LvpxdDuNTTzdo aj1k2u6DD2YcpzwZw33suqSZ8Z067IO6QK6MACFiey7GLx20WfyV2jHJR7Xkk8krzfKYOYFCgTcrD umVmA+HtbRJJtMAww/hEmGGJy0ReXFD+PgDEPaVcLsmjCAHM/6gRjN6k/UnZPVMIWwo0=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jIZIR-000553-B2; Sun, 29 Mar 2020 14:52:19 +0000 Received: from 44.142.6.51.dyn.plus.net ([51.6.142.44] helo=debian) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jIZIR-0004aT-0n; Sun, 29 Mar 2020 14:52:19 +0000 Date: Sun, 29 Mar 2020 15:52:16 +0100 From: Wei Liu To: Roger Pau Monne Message-ID: <20200329145216.qu52ii5zuh2uea3l@debian> References: <20200320184240.41769-1-roger.pau@citrix.com> <20200320184240.41769-2-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200320184240.41769-2-roger.pau@citrix.com> User-Agent: NeoMutt/20180716 Subject: Re: [Xen-devel] [PATCH v8 1/3] x86/tlb: introduce a flush HVM ASIDs flag X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , Andrew Cooper , Tim Deegan , George Dunlap , Jan Beulich , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Fri, Mar 20, 2020 at 07:42:38PM +0100, Roger Pau Monne wrote: > Introduce a specific flag to request a HVM guest linear TLB flush, > which is an ASID/VPID tickle that forces a guest linear to guest > physical TLB flush for all HVM guests. > > This was previously unconditionally done in each pre_flush call, but > that's not required: HVM guests not using shadow don't require linear > TLB flushes as Xen doesn't modify the guest page tables in that case > (ie: when using HAP). Note that shadow paging code already takes care > of issuing the necessary flushes when the shadow page tables are > modified. > > In order to keep the previous behavior modify all shadow code TLB > flushes to also flush the guest linear to physical TLB. I haven't > looked at each specific shadow code TLB flush in order to figure out > whether it actually requires a guest TLB flush or not, so there might > be room for improvement in that regard. > > Also perform ASID/VPIT flushes when modifying the p2m tables as it's a > requirement for AMD hardware. Finally keep the flush in > switch_cr3_cr4, as it's not clear whether code could rely on > switch_cr3_cr4 also performing a guest linear TLB flush. A following > patch can remove the ASID/VPIT tickle from switch_cr3_cr4 if found to > not be necessary. > > Signed-off-by: Roger Pau Monné As far as I can tell all previous comments are addressed: Reviewed-by: Wei Liu