From: Baoquan He Date: Mon, 30 Mar 2020 08:04:56 +0000 Subject: Re: [PATCH v3 0/5] mm: Enable CONFIG_NODES_SPAN_OTHER_NODES by default for NUMA Message-Id: <20200330080456.GJ9942@MiWiFi-R3L-srv> List-Id: References: <1585420282-25630-1-git-send-email-Hoan@os.amperecomputing.com> <20200329001924.GS3039@MiWiFi-R3L-srv> <20200330074426.GB14243@dhcp22.suse.cz> In-Reply-To: <20200330074426.GB14243@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: mmorana@amperecomputing.com, Catalin Marinas , Heiko Carstens , "open list:MEMORY MANAGEMENT" , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Alexander Duyck , linux-s390@vger.kernel.org, Michael Ellerman , x86@kernel.org, Mike Rapoport , Christian Borntraeger , Ingo Molnar , Hoan Tran , Benjamin Herrenschmidt , Pavel Tatashin , lho@amperecomputing.com, Vasily Gorbik , Vlastimil Babka , Will Deacon , Borislav Petkov , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Oscar Salvador , linux-kernel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" On 03/30/20 at 09:44am, Michal Hocko wrote: > On Sun 29-03-20 08:19:24, Baoquan He wrote: > > On 03/28/20 at 11:31am, Hoan Tran wrote: > > > In NUMA layout which nodes have memory ranges that span across other nodes, > > > the mm driver can detect the memory node id incorrectly. > > > > > > For example, with layout below > > > Node 0 address: 0000 xxxx 0000 xxxx > > > Node 1 address: xxxx 1111 xxxx 1111 > > > > Sorry, I read this example several times, but still don't get what it > > means. Can it be given with real hex number address as an exmaple? I > > mean just using the memory layout you have seen from some systems. The > > change looks interesting though. > > Does this make it more clear? > physical address range and its node associaion > [0 0 0 0 1 1 1 1 0 0 0 0 1 1 1 1 0 0 0 0 1 1 1 1] I later read it again, have got what Hoan is trying to say, thanks. I think the change in this patchset makes sense, still have some concern though, let me add comment in other thread.