Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jIqON-0002MH-QM for mharc-grub-devel@gnu.org; Mon, 30 Mar 2020 05:07:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37015) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIqOH-0002KV-1E for grub-devel@gnu.org; Mon, 30 Mar 2020 05:07:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIqOE-0000Bb-O2 for grub-devel@gnu.org; Mon, 30 Mar 2020 05:07:27 -0400 Received: from m4a0073g.houston.softwaregrp.com ([15.124.2.131]:55506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jIqOE-0008Ey-G8 for grub-devel@gnu.org; Mon, 30 Mar 2020 05:07:26 -0400 Received: FROM m4a0073g.houston.softwaregrp.com (15.120.17.147) BY m4a0073g.houston.softwaregrp.com WITH ESMTP; Mon, 30 Mar 2020 09:05:21 +0000 Received: from M9W0067.microfocus.com (2002:f79:be::f79:be) by M4W0335.microfocus.com (2002:f78:1193::f78:1193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 30 Mar 2020 09:04:53 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (15.124.72.12) by M9W0067.microfocus.com (15.121.0.190) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Mon, 30 Mar 2020 09:04:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BEnxVONIh6PQ22pXAehlVlEYewrH5kScaVVyHsEDsu0vWgsQuKBBnUVkSYyOTN1ShPowfA68Yf15gNN0OA6CPiyXQqZ5esQ9JMTlMAWfY2YE+2nnSlVWRjyTXqwCp3k1qSrcJ0J2dEnZn20YWzsLHRbYHmiAUJHJKfQ/uLFsi/3Wv23bErv/89BoPlLaE2cx+jJ3mI+GN6B1Jkabea5PiiCNlw7JCZSOMcv7G5eFu7fkscNCNswaBTmYwbfe5CW38UjsDV0GPQe53bwkWHpoaYI1JKWNTbvtzWwAJCYPwWjwruuik8bB1MWmTYqaMVenAqr1Vcr4DPTckwXedMRHLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sv1BtK1SmYZ2FN0JWc/rM5CB41+SrMmIW/25jaJTliQ=; b=cDEXFboTQrL4GSIEs0GuBrcUBbr7OHxP6e/ceGcusAlBmH1pW0FkOE3PwRCQWj07rFkbq5RHBe4/gOnlvkz6K1z4msp7bW/z+u+c2kI5OHFnr1Synvy0xN3dkoU8kMIOwHm6SuDT6h3B0r1TkGgs8uGE6aj7irapU3Ik4hqWcWKNP0A3/2VbJSh+FMtwqqX/tbcwVMae/1VXOBxd+0BYsJqyaVbY/CHoEDvDjURn4LeMRl/6dasi0AXZ49rUCBbYpzKGn+9J8mJK209O3Udw0VAninWCVKc+kps7VKpuBR+R75XR42UcZG/C69YJvlAX3N0qR7vnVNgRErI3eMa60g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=MChang@suse.com; Received: from BY5PR18MB3140.namprd18.prod.outlook.com (2603:10b6:a03:1a1::17) by BY5PR18MB3329.namprd18.prod.outlook.com (2603:10b6:a03:1a7::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Mon, 30 Mar 2020 09:04:52 +0000 Received: from BY5PR18MB3140.namprd18.prod.outlook.com ([fe80::a404:f256:fbe8:c2d]) by BY5PR18MB3140.namprd18.prod.outlook.com ([fe80::a404:f256:fbe8:c2d%4]) with mapi id 15.20.2856.019; Mon, 30 Mar 2020 09:04:52 +0000 Date: Mon, 30 Mar 2020 17:04:42 +0800 From: Michael Chang To: The development of GNU GRUB CC: Olaf Hering , Subject: Re: [PATCH v1] fix kernel cmdline corruption Message-ID: <20200330090442.GC6065@mercury> References: <20200318111312.21684-1-olaf@aepfle.de> <20200319074828.GA3325@mazu> <20200326213301.rkjeb3ljdlaywgmd@tomti.i.net-space.pl> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200326213301.rkjeb3ljdlaywgmd@tomti.i.net-space.pl> User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: HK2PR04CA0070.apcprd04.prod.outlook.com (2603:1096:202:15::14) To BY5PR18MB3140.namprd18.prod.outlook.com (2603:10b6:a03:1a1::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mercury (36.226.140.151) by HK2PR04CA0070.apcprd04.prod.outlook.com (2603:1096:202:15::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Mon, 30 Mar 2020 09:04:50 +0000 X-Originating-IP: [36.226.140.151] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b435a954-2a14-42e1-1d8a-08d7d4896811 X-MS-TrafficTypeDiagnostic: BY5PR18MB3329: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-Forefront-PRVS: 0358535363 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR18MB3140.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(4636009)(39860400002)(396003)(376002)(366004)(136003)(346002)(9686003)(8676002)(16526019)(6666004)(33656002)(81166006)(33716001)(316002)(81156014)(6916009)(1076003)(6496006)(52116002)(956004)(86362001)(8936002)(5660300002)(26005)(186003)(9576002)(55016002)(478600001)(66556008)(4326008)(2906002)(966005)(66476007)(66946007); DIR:OUT; SFP:1102; Received-SPF: None (protection.outlook.com: suse.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BppG+KhMgMzlI/rbii1eXlPx+1te50fxBP1uQcqwSWfsAJJAY42hXHG37mFNHBVjQ2+xRnX/LOlSXPOBlVeK+wE4Bw+I3QLvM03pNkyQwisXXDE/2C++N8M+IWBdkmY5zbgix4a4RceqdYPGH6CPxZtRzfJRITeqFrERATpF+ZDbglB/6V9ldq7FiLxvHRurRxh0e7jnDWwzhFtf1pAOsVmuTGlE8wDmuUwV7JetIMhYto/Giop2G3G98/0o5KFGwg8eC0t0sEXb04X95EpXdVEBqQ14xzcwpgzOMDrpFnsT7LswHukRxFIkEb8ZDPIt3vwW0w+Fqz91T7n6TCBPLB9OkAftIbm0Nz0/r9SvxIWNk+CWJnLKOipVnrO6oTdtvoycRFgRP4ZqD+dmkYi1i7+kYPNJhfbCXTpfiR7VDYc0A1zdG9EfyeRgGBTCizijXji8A13QRGN5/9hSh4DAgieUNmBz03s20r/XXFkvw1v5rVDguYQk7kDhdWv6wrwmHoJyqag3hb2mR/GYCCLhaQ== X-MS-Exchange-AntiSpam-MessageData: pOr2s84h8heVmj+mSAGe8VSd+FdnzTTec3CBNlAzECCM7BoAX9DRrKaMvPwrIuYvedu7t+sJ6BaoAtNdZaRROYXQp++9VM4a3ia6MdOqy0yPs238s1eycjwQV+z30V+i26w6Fotr8lBguF89u0SZ8g== X-MS-Exchange-CrossTenant-Network-Message-Id: b435a954-2a14-42e1-1d8a-08d7d4896811 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2020 09:04:52.0583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ung62VAoPjlrgvU5PkNT3AmTpRvXdI8RT4rkEn5ZBPcLobxW1JEMQCsg7bIb3g2j X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR18MB3329 X-OriginatorOrg: suse.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 15.124.2.131 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2020 09:07:34 -0000 On Thu, Mar 26, 2020 at 10:33:01PM +0100, Daniel Kiper wrote: > CC-ing Vladimir... > > On Thu, Mar 19, 2020 at 03:48:28PM +0800, Michael Chang wrote: > > Hi Olaf, > > > > The patch rang a bell to me and eventually I figured out that I had > > similar patch posted. > > > > https://lists.gnu.org/archive/html/grub-devel/2018-04/msg00038.html > > Yeah, it looks that it fell through the cracks... > > > In short, the issue is not only in the fix itself, but also to take care > > and provide a measure to avoid incompatible grub.cfg before and after > > the patch. > > > > To recap, there were two options provided to deal with the compatibilty > > issue. > > > > 1. Introduce a shell variable to disable the change, whenever anything > > goes wrong. > > > > 2. Use readonly feature variable similar to $feature_menuentry_id that > > can be used to detect capability and apply settings accordingly, thus > > still fulfill the requirement of one grub.cfg can work for all versions > > IMHO. > > > > I am in favour of #2, but still they didn't seem to have upstream's > > consent yet. > > Michael, please prepare a patch and CC Olaf and Vladimir on it. OK. I will do so. May I ask is it for 2.06 release material or not ? As the deadline is drawing very near I'd better to have confirmation first. Thanks, Michael > > Daniel > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel